Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement value validation using value classes #68

Open
happy5214 opened this issue May 11, 2022 · 0 comments · May be fixed by #196
Open

Re-implement value validation using value classes #68

happy5214 opened this issue May 11, 2022 · 0 comments · May be fixed by #196
Labels
hed 3 HED 3-specific issues important Important issues schema Schema parsing validation Tag validation issues

Comments

@happy5214
Copy link
Member

HED 3 introduced the concept of value classes to represent the sets of legal values for each value-taking tag. This will make value validation more robust and schema-driven, as well as allow library schemas to define their own value classes. In order to support value validation using value classes, the value classes have to be parsed (an initial implementation was added as part of the rewrite in #56), and a new validation function must be written to use the value class data required for a given tag. HED 2 will continue to use the existing implementation.

@happy5214 happy5214 added hed 3 HED 3-specific issues validation Tag validation issues schema Schema parsing labels May 11, 2022
@happy5214 happy5214 added this to the 4.0.0 milestone May 11, 2022
@happy5214 happy5214 removed this from the 4.0.0 milestone May 26, 2023
@happy5214 happy5214 added the important Important issues label Feb 25, 2024
@happy5214 happy5214 linked a pull request Sep 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hed 3 HED 3-specific issues important Important issues schema Schema parsing validation Tag validation issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant