You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The expected issue lists in the event.spec.js test suite contain some redundant code, namely repeated calls to generateIssue and converterGenerateIssue. In the future, we should consider whether it would be desirable to condense these lists to include just the data and move those calls to the validator base functions.
For example, the current test in dataset.spec.js (a good example of one with multiple issue types), edited to the form of event.spec.js, would be:
The expected issue lists in the
event.spec.js
test suite contain some redundant code, namely repeated calls togenerateIssue
andconverterGenerateIssue
. In the future, we should consider whether it would be desirable to condense these lists to include just the data and move those calls to the validator base functions.For example, the current test in
dataset.spec.js
(a good example of one with multiple issue types), edited to the form ofevent.spec.js
, would be:Several possibilities exist for condensing this. Some are listed below.
The text was updated successfully, but these errors were encountered: