Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONSET_INSET_OFFSET_ERROR renamed -- need support for Duration and Delay validation #140

Open
VisLab opened this issue Mar 5, 2024 · 1 comment
Open

ONSET_INSET_OFFSET_ERROR renamed -- need support for Duration and Delay validation #140

VisLab opened this issue Mar 5, 2024 · 1 comment
Labels
hed 3 HED 3-specific issues validation Tag validation issues
Milestone
3.16.0

Comments

@VisLab
Copy link
Member

VisLab commented Mar 5, 2024

The ONSET_INSET_INSET_OFFSET_ERROR has been renamed TEMPORAL_TAG_ERROR in the HED specification so that Duration and Delay errors will fall under this umbrella.

What is the status of validation for the Duration and Delay tags beyond the top-level-tag group? How is the requirement that at most one Duration and one Delay can be in a tag group being handled?

Ref: PRs hed-python#879 and hed-specification#567.
@happy5214 happy5214 mentioned this issue Mar 8, 2024
Open
@happy5214 happy5214 added this to the 3.14.0 milestone Mar 8, 2024
@happy5214 happy5214 added hed 3 HED 3-specific issues validation Tag validation issues labels Mar 8, 2024
@happy5214
Copy link
Member

There is currently no specific support for validating Delay and Duration groups. I have opened #141 for that.

@happy5214 happy5214 modified the milestones: 3.13.4, 3.14.0 Mar 8, 2024
@happy5214 happy5214 changed the title ONSET_INSET_OFFSET_ERROR renamed -- need support for DURATION and DELAY validation ONSET_INSET_OFFSET_ERROR renamed -- need support for Duration and Delay validation Mar 15, 2024
@happy5214 happy5214 modified the milestones: 3.14.0, 3.15.0 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hed 3 HED 3-specific issues validation Tag validation issues
Projects
None yet
Milestone
3.16.0
Development

No branches or pull requests
2 participants
@VisLab @happy5214