-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would you accept a PR to allow loading pptx from buffer OR file path? #119
Comments
MP70
changed the title
Would you accept a PR to allow loading pptx from buffer instead of file path?
Would you accept a PR to allow loading pptx from buffer OR file path?
Apr 20, 2023
Has there been any follow up regarding this? I seem to be in a similar position. |
This project seems pretty dead IMO. I ended up not using it. Feel free to use my code above as a starting point if you'd like, consider it MIT licensed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue with loading PowerPoint file from buffer
The
save()
method allows you to specify either a callback (passing buffer) or file path, but when loading a PowerPoint file, you must pass a file path. This can be pretty inconvenient in cases where you already have the PowerPoint file contents in a buffer.Proposed solution
To address this issue, can we please add support for loading from a buffer as well as a file path.
I've quickly scanned your code, and at first glance it looks like it's as simple as changing
loadExistingPPTX()
:node-pptx/lib/presentation.js
Lines 99 to 103 in 7e137b5
To something like:
Obviously we'd also need to change the variable name to
templateFile
or similar and any other housekeeping as needed.Would you accept a PR from me along these lines to add this feature?
The text was updated successfully, but these errors were encountered: