New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and pass around iovec_iters in the network stack #94

Open

heatd opened this issue Jan 6, 2024 · 0 comments

Labels

Owner

heatd commented Jan 6, 2024

The network stack was written pre-iovec_iter, and as such handrolls a lot of the iovec_iter logic. For instance:

unix.cpp was written post-iovec_iter and as such creates its own iovec_iter
tcp.cpp, udp.cpp, icmp.cpp do not use iovec_iter and handroll the logic

This would probably mean that we would want to pass around a structure different from msghdr, with a iovec_iter instead of a struct iovec.

#93 is related to this. While the conversion doesn't happen, sendmsg can't be used with !IOVEC_USER.

heatd added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment