Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use hardcoded server url #11

Open
ashu8912 opened this issue Jul 11, 2023 · 0 comments
Open

Don't use hardcoded server url #11

ashu8912 opened this issue Jul 11, 2023 · 0 comments
Assignees

Comments

@ashu8912
Copy link
Member

While making request to external proxy on the backend here(

return fetch(`http://localhost:4466/externalproxy`, {
and
export function fetchChartValues(packageID: string, packageVersion: string) {
) We are using hardcoded server url, this should not be the case as when if something is already running on this port the user can start server on a different port, in that case this request will fail.

Possible solution
One way that i could think of is, Pass the server url from elctron main process to renderer process and use that as the server url here

Acceptance criteria
When making request to external proxy we use the dynamic server link generated in the electron main process

@joaquimrocha joaquimrocha added this to the 0.20.0 milestone Aug 8, 2023
@joaquimrocha joaquimrocha removed this from the v0.20.0 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants