Skip to content

WIP: frontend: router: Add lazy loading of routes for code splitting #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

WIP: frontend: router: Add lazy loading of routes for code splitting #1961

wants to merge 12 commits into from

Conversation

illume
Copy link
Contributor

@illume illume commented May 6, 2024 •
edited
Loading

No description provided.

@sniok
Copy link
Contributor

sniok commented May 6, 2024

Splitting on every route might be an overkill imho, usually it's only needed in components that import big libraries (for example EditorDialog that imports monaco would be good case for lazy loading). Otherwise it'll just generate a lot of small chunks which might negatively impact build time

@illume illume force-pushed the code-splitting branch from 6a777ac to b7570fd Compare May 6, 2024 13:08
@illume
frontend: common: Remove Logviewer Terminal from common
d781b47 
Because they are not used in many modules, and so they
should not be loaded all the time by putting them in the
common/index.

Additionally, this means that the code is only loaded when
the pod details route is loaded.

Signed-off-by: René Dudfield <[email protected]>
@illume illume force-pushed the code-splitting branch from 5661978 to d781b47 Compare May 7, 2024 07:38
@illume illume force-pushed the code-splitting branch from b47b021 to 0cfabe9 Compare May 8, 2024 13:02
illume added 2 commits May 8, 2024 16:45
@illume
frontend: Update mui imports to use default imports
781d13f 
This speeds up the development server when making changes.

Signed-off-by: René Dudfield <[email protected]>
@illume
Makefile: Fix run-backend/frontend on win, make faster on linux
4d20e69 
This works with Windows, because before setting environment
variables did not work when using cmd or powershell.

Also use nice -19 to speed things up on WSL a lot. Because in a VM
it can be twice as slow normally. It's only getting priority when
compiling, so that is usually what we want.

Signed-off-by: René Dudfield <[email protected]>
@illume illume mentioned this pull request Nov 8, 2024
Open
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
Headlamp Release Plan / Roadmap
Status: Queued
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@illume @sniok @k8s-triage-robot @k8s-ci-robot