Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full screen distortion #2327

Closed
wants to merge 5 commits into from
Closed

Conversation

edisonout
Copy link
Member

Will fix #307 and helps with #2293

What I've got so far in full screen is the level with no distortion and if's too small, have it centred and display black bars above/below or left/right (unless the level already has a background colour).

Still on my todo list:

[x] fix camera changes when entering different levels
[x] fix camera changes when going from fullscreen to windowed mode or vice versa
[ ] fix the camera for different gamestates
[x] sort out the background colours so all levels have black bars/come up with a better way of doing it
[ ] fix parallax backgrounds
[ ] test all the levels and make sure I haven't messed with anything else
[ ] test what happens on tiny computers
[ ] test what happens on high resolution screens (at least 1344 pixels high)

@edisonout edisonout added the wip label May 7, 2015
@niamu niamu added this to the Finally Be Fine milestone May 7, 2015
@edisonout
Copy link
Member Author

Right, I think the levels now work in both fullscreen and windowed mode as long as you don't switch between them.

@8bitgentleman
Copy link
Contributor

If we can get this into the Monday release that would be awesome.

@edisonout
Copy link
Member Author

The menu gamestates (excluding selecting characters/costumes) have now been updated to work in both windowed/fullscreen mode. The arrow positioning isn't correct in either mode for the "game" submenu of "options" and I think verticalparticles might not always be loading when you want it to - if you return to some screens it's just black & on the "video" menu, to switch between fullscreen/windowed, I've had to load it again.

I'm not going to be able to finish this tonight - I think we should leave this for the next release.

@niamu
Copy link
Member

niamu commented May 22, 2015

Can we get an update on this pull request? I'd like to help push this the rest of the way for the bugfix release this weekend.

@edisonout
Copy link
Member Author

I haven't done anything else for this pull request recently. If I got my act together I could probably sort out the other gamestates today. Then we're just left with the black bar issue around the levels - currently it means having to add the background colour manually. There's probably a better way of doing it, but I haven't come up with it yet.
.

@edisonout edisonout mentioned this pull request May 23, 2015
5 tasks
@edisonout edisonout closed this May 23, 2015
@edisonout edisonout modified the milestone: Yahoo! May 23, 2015
@edisonout edisonout deleted the lines branch June 3, 2015 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting vertical lines and distorted graphics at Full screen mode.
3 participants