use startup.py instead of --code option

[haubourg]

This is much leaner and the way the documentation recommends it.

Let's dig why it didn't work at start in my setup :)

[nicogodet]

I need to confirm on my test machine but qgis_constrained_settings.py should looks like :

custom-osgeo4w-qgis/qgis-custom/apps/qgis-custom/qgis_constrained_settings.py

Lines 97 to 98 in 3c26b18

	if __name__ == "__main__":
	main()

-if __name__ == "__main__":
+if __name__ == "startup": 
   main()

https://github.com/qgis/QGIS/blob/23036461dd23846b1e820114a83588ba5c269373/src/python/qgspythonutilsimpl.cpp#L206-L208

I ran these 3 lines in QGIS python console and I add print(__name__) before main() definition.

> spec = importlib.util.spec_from_file_location('startup','C:/Users/Nicolas Godet/AppData/Roaming/QGIS/QGIS3/startup.py')
> module = importlib.util.module_from_spec(spec)
> spec.loader.exec_module(module)
startup

So main() was never called...

[haubourg]

@nicogodet thanks for raising this. I have no windows machine to test this by now but this makes sense. Tell me when you confirm this on your test machine. Any PR welcome :)

[nicogodet]

@haubourg I confirm it should be as described in my previous message. I will prepare a PR.

[nicogodet]

See e4650cd