`System.FilePath.Windows.getSearchPath` misbehaves on unix

[hasufell]

ghci> import System.FilePath.Windows
ghci> getSearchPath
["/home/hasufell/.cabal/bin:/home/hasufell/.opam/default/bin:/home/hasufell/.cabal/bin:/home/hasufell/.ghcup/bin:/home/hasufell/.bun/bin:/home/hasufell/.local/bin:/home/hasufell/go/bin:/home/hasufell/.cargo/bin:/home/hasufell/.local/texlive/bin/x86_64-linux:/home/hasufell/.nix-profile/bin:/home/hasufell/.cargo/bin:/home/hasufell/.local/bin:/home/hasufell/bin:/usr/local/bin:/usr/bin:/bin:/home/hasufell/.cabal/bin:/home/hasufell/.cabal/bin:/home/hasufell/.opam/default/bin:/home/hasufell/.cabal/bin:/home/hasufell/.ghcup/bin:/home/hasufell/.bun/bin:/home/hasufell/.local/bin:/home/hasufell/go/bin:/home/hasufell/.cargo/bin:/home/hasufell/.local/texlive/bin/x86_64-linux:/home/hasufell/.nix-profile/bin:/home/hasufell/.cargo/bin:/home/hasufell/.local/bin:/home/hasufell/bin:/usr/local/bin:/usr/bin:/bin"]

It appears to use the getEnv for the current platform, but then the windows flavored splitSearchPath.

[sergv]

The premise is somewhat unclear, the module is designated for Windows, presumably expecting Windows conventions. Should it work on unix at all?

On a system that doesn't follow the Windows conventions, e.g. PATH on Windows expects to be separated with ; but on unix it's :, what else could the function do?

[hasufell]

System.FilePath.Windows is functional on unix and vice versa. It allows us to handle filepaths from other platforms (e.g. tar, which is always unix filepaths regardless of platform).

So there shouldn't be any code in those modules that reacts to "current platform". This is true already, except for getSearchPath.

[hasufell]

Or to put it in another way: IO functionality that is windows specific should not be exposed on unix.

Only the module that deals with "current platform" should expose getSearchPath (those are System.FilePath and System.OsPath).

That's why it's going to be moved to directory package to also avoid inlining of code: haskell/directory#198