Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the internal queue monadic #41

Open
treeowl opened this issue Aug 30, 2016 · 1 comment
Open

Make the internal queue monadic #41

treeowl opened this issue Aug 30, 2016 · 1 comment

Comments

@treeowl
Copy link
Contributor

treeowl commented Aug 30, 2016

Data.Graph.Inductive.Internal.Queue isn't efficient for persistent use. It would be easier to ensure that it's not accidentally used persistently if it's given a monadic interface. It should probably also be benchmarked against other queue implementations, such as Control.Monad.Queue.Corec from control-monad-queue, my own considerable simplification thereof, or perhaps something fancier in ST.

@ivan-m
Copy link
Contributor

ivan-m commented Aug 30, 2016

I'm hesitant to add any dependencies due to the fact that fgl is in the Platform. But I don't disagree that the various Data.Graph.Inductive.Internal.* modules aren't all that great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants