Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intset-benchmarks no longer build on windows. #885

Open
AndreasPK opened this issue Dec 23, 2022 · 4 comments · May be fixed by #886
Open

intset-benchmarks no longer build on windows. #885

AndreasPK opened this issue Dec 23, 2022 · 4 comments · May be fixed by #886
Labels
maintainability

Comments

@AndreasPK
Copy link
Contributor

On commit 468aa9d I get this after a checkout and running cabal run intset-benchmarks I get this error:

cabal run intset-benchmarks
Build profile: -w ghc-9.4.2 -O1
In order, the following will be built (use -v for more details):
 - containers-tests-0 (lib) (first run)
 - containers-tests-0 (bench:intset-benchmarks) (first run)
Preprocessing library for containers-tests-0..
Error: cabal.exe: can't find source for Data\Containers\ListUtils in src,
tests,
C:\ghc\msys64\home\andi\repos\containers\dist-newstyle\build\x86_64-windows\ghc-9.4.2\containers-tests-0\build\autogen,
C:\ghc\msys64\home\andi\repos\containers\dist-newstyle\build\x86_64-windows\ghc-9.4.2\containers-tests-0\build\global-autogen

Error: cabal.exe: Failed to build containers-tests-0 (which is required by
bench:intset-benchmarks from containers-tests-0).

Maybe some symbolic link use that breaks on windows?
@treeowl
Copy link
Contributor

treeowl commented Dec 23, 2022

Hmmm... Yeah, I think we use symbolic links to share files between containers and containers-tests. Do you know a better way?

@AndreasPK
Copy link
Contributor Author

Indeed

andi@Ryzen MINGW64 ~/repos/containers
$ cat containers-tests/src
../containers/src

But this should be a symbolic link.

Seems more compatible to me to use

  hs-source-dirs:   ../containers/src, tests

Inside containers-tests.cabal instead of using a symbolic link. As they are notoriously difficult to get to work by default on windows.

@treeowl
Copy link
Contributor

treeowl commented Dec 23, 2022

Can you try it and open a PR?

@AndreasPK
Copy link
Contributor Author

I opened #886

@AndreasPK AndreasPK linked a pull request Dec 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintainability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a relative src dir path in containers-tests instead of a symlink. AndreasPK/containers
3 participants
@treeowl @AndreasPK @meooow25