Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"HsYAML is tested using YAML-Test-Suite" #63

Open
sjakobi opened this issue Jun 16, 2022 · 4 comments
Open

"HsYAML is tested using YAML-Test-Suite" #63

sjakobi opened this issue Jun 16, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@sjakobi
Copy link
Collaborator

sjakobi commented Jun 16, 2022

…says the readme.

Are these tests automated somewhere? I suspect not. They probably should be though, so we don't accidentally break compatibility with the YAML spec.

@sjakobi
Copy link
Collaborator Author

sjakobi commented Jun 16, 2022

I think the run-tml[2] commands of the internal yaml-test executable are intended to execute this YAML-Test-Suite:

HsYAML/src-test/Main.hs

Lines 134 to 135 in 603d8a2

hPutStrLn stderr " run-tml run/validate YAML-specific .tml file(s)"
hPutStrLn stderr " run-tml2 run/validate YAML-specific .tml file(s) while preserving comments"

Could this test suite be executed in CI?!

@sjakobi sjakobi added the help wanted Extra attention is needed label Jun 16, 2022
@andreasabel
Copy link
Member

There is this testsuite which is registered in HsYAML.cabal: https://github.com/haskell-hvr/HsYAML/blob/603d8a23338db6abe5105c96ece182f2d930cf1f/tests/Tests.hs

@sjakobi
Copy link
Collaborator Author

sjakobi commented Jun 16, 2022

There is this testsuite which is registered in HsYAML.cabal: https://github.com/haskell-hvr/HsYAML/blob/603d8a23338db6abe5105c96ece182f2d930cf1f/tests/Tests.hs

Yes, this testsuite is also mentioned in the README, but it doesn't seem to test compatibility with the YAML spec.

@andreasabel
Copy link
Member

Could this test suite be executed in CI?!

If this is added as a test-suite in HsYAML.cabal with build-tool-depends pointing to the executable, then it would be run in the automated CI without manual patching (just regeneration of haskell-ci.yml).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants