Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: EKS should support 100.64.0.0/10 and 198.19.0.0/16 #37396

Open
taliesins opened this issue May 9, 2024 · 2 comments
Open

[Enhancement]: EKS should support 100.64.0.0/10 and 198.19.0.0/16 #37396

taliesins opened this issue May 9, 2024 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.

Comments

@taliesins
Copy link

Description

EKS supports 100.64.0.0/10 and 198.19.0.0/16 CIDR blocks as per:
https://aws.amazon.com/about-aws/whats-new/2018/10/amazon-eks-now-supports-additional-vpc-cidr-blocks/

If you try to use these CIDR blocks you will receive an error

╷
│ Error: invalid value for kubernetes_network_config.0.service_ipv4_cidr (must be within 10.0.0.0/8, 172.16.0.0/12, or 192.168.0.0/16)
│ 
│   with module.eks-cluster.module.eks_blueprints.aws_eks_cluster.this[0],
│   on .terraform/modules/eks-cluster.eks_blueprints/main.tf line 27, in resource "aws_eks_cluster" "this":
│   27: resource "aws_eks_cluster" "this" {
│ 
╵

The validation expression to fix is: https://github.com/hashicorp/terraform-provider-aws/blob/fbad5d3b00f58789b2b70fc6188ea240f1191e49/internal/service/eks/cluster.go#L191C8-L191C168

In big organizations that have grown through aquisitions, they tend to have a very fragmented ip spaces. So it would be great if we could make use of this extra ip space.

Affected Resource(s) and/or Data Source(s)

aws_eks_cluster

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

None

@taliesins taliesins added the enhancement Requests to existing resources that expand the functionality or scope. label May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/eks Issues and PRs that pertain to the eks service. label May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 9, 2024
@acwwat
Copy link
Contributor

acwwat commented May 10, 2024

I could be wrong, but It seems that EKS services still need to run within the RFC 1918 private IP range (as required by the CreateCluster API), but worker nodes can leverage the extended range using CNI custom networking. This blog post provides a Terraform example for such a setup.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

No branches or pull requests

3 participants