Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Properties to image #64

Open
JoeyG1973 opened this issue Jun 6, 2022 · 4 comments
Open

Add Properties to image #64

JoeyG1973 opened this issue Jun 6, 2022 · 4 comments
Assignees

Comments

@JoeyG1973
Copy link

JoeyG1973 commented Jun 6, 2022

Community Note

Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Please allow the ability to add properties to the image

Use Case(s)

openstack image set --property key=value needs to be run after the image is created using an external process.

Setting properties in OpenStack for the image should be part of packer proper

Potential configuration

"properties": {
	                 "os_distro": "ubuntu"
                         "os_version": "22.04"
	             }

Potential References

@nywilken nywilken self-assigned this Jul 22, 2022
@nywilken
Copy link
Member

Hi @JoeyG1973 thanks for reaching out here. This is a community maintained plugin so the Packer team won't work on this change. But we are happy to review a pull-request if you are or a member of the community is interested in making the change.

That said, are these properties different from the properties that can be set via the the external_source_image_properties?

@JoeyG1973
Copy link
Author

JoeyG1973 commented Sep 20, 2022

Hi @JoeyG1973 thanks for reaching out here. This is a community maintained plugin so the Packer team won't work on this change. But we are happy to review a pull-request if you are or a member of the community is interested in making the change.

That said, are these properties different from the properties that can be set via the the external_source_image_properties?

Hi @nywilken,

The description on external_source_image_properties clarifies nothing so I am not really sure what it is supposed to do. :)

@JoeyG1973
Copy link
Author

I am still trying to figure out what https://www.packer.io/plugins/builders/openstack#external_source_image_properties is supposed to be. Is it a filter on properties for what external image to choose or does it set properties on the packer output image?

@cortexx
Copy link

cortexx commented Oct 31, 2023

Hello,

I asked myself the same question a few days ago and found your issue.

So here my 2 cents:

  • As defined here, the external_source_image_properties is used as options given during image creation
  • After some tests, I confirm that added properties are properly set to the generated image
  • I found the documentation a bit confusing on this subject

Hoping that my comment will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants