[openstack] choke on volumes which end up in error state

[ghost]

This issue was originally opened by @dave2 as hashicorp/packer#8737. It was migrated here as a result of the Packer plugin split. The original body of the issue is below.

---

Overview of the Issue

Packer chokes waiting on a volume to become ready if the volume instead transitions to 'error' state. This should be caught and immediately passed back to the user, along with abandoning any build in progress.

Probably needs to be tested for as explicit state somewhere around here:
https://github.com/hashicorp/packer/blob/master/builder/openstack/volume.go#L35

Reproduction Steps

Specify a block device smaller than the launch image allows. Seems to always force error state, should choke on that.

Packer version

1.5.1

Simplified Packer Buildfile

Any valid openstack build file will do this, since it's a backend issue with OpenStack and errors.

Operating system and Environment details

Ubuntu 18.04 64-bit. The OpenStack deployment used is a private cloud implementation.

Log Fragments and crash.log files

==> openstack: Creating volume...
==> openstack: Waiting for volume packer_5e45dff6-e5e1-06f4-bda8-60b973283d77 (volume id: 6730cb8e-ad13-401e-a52d-535aad2ade66) to become available...
2020/02/13 23:47:04 packer-builder-openstack plugin: Waiting for volume creation status: creating
2020/02/13 23:47:07 packer-builder-openstack plugin: Waiting for volume creation status: creating
2020/02/13 23:47:09 packer-builder-openstack plugin: Waiting for volume creation status: error
2020/02/13 23:47:11 packer-builder-openstack plugin: Waiting for volume creation status: error
[.. endlessly reports error ..]