You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I also noticed another oddity when creating volumes in separate namespaces where the volume name is the same. When the name is the same for two volumes in separate nomad namespaces only one volume was created on the storage side, which was accessable by both jobs in different namespaces.
In the CSI spec, the CreateVolumeRequest.name field is intended as both an idempotency token and a suggested name for the storage provider. Nomad compounds this arguably unfortunate-but-unavoidable design decision by overloading it further to be the display name for the volume. If you send CreateVolumeRequest with the same name, that's supposed to tell the storage provider that the volume is the same one.
We should validate that the same name isn't being reused for different volumes for the same plugin, in the RPC handler.
The text was updated successfully, but these errors were encountered:
@ron-savoia wrote in #18741 (comment)
In the CSI spec, the
CreateVolumeRequest.name
field is intended as both an idempotency token and a suggested name for the storage provider. Nomad compounds this arguably unfortunate-but-unavoidable design decision by overloading it further to be the display name for the volume. If you sendCreateVolumeRequest
with the same name, that's supposed to tell the storage provider that the volume is the same one.We should validate that the same name isn't being reused for different volumes for the same plugin, in the RPC handler.
The text was updated successfully, but these errors were encountered: