Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: volume.name uniqueness is not enforced per-plugin #20530

Open
tgross opened this issue May 3, 2024 · 0 comments
Open

CSI: volume.name uniqueness is not enforced per-plugin #20530

tgross opened this issue May 3, 2024 · 0 comments

Comments

@tgross
Copy link
Member

tgross commented May 3, 2024

@ron-savoia wrote in #18741 (comment)

I also noticed another oddity when creating volumes in separate namespaces where the volume name is the same. When the name is the same for two volumes in separate nomad namespaces only one volume was created on the storage side, which was accessable by both jobs in different namespaces.

In the CSI spec, the CreateVolumeRequest.name field is intended as both an idempotency token and a suggested name for the storage provider. Nomad compounds this arguably unfortunate-but-unavoidable design decision by overloading it further to be the display name for the volume. If you send CreateVolumeRequest with the same name, that's supposed to tell the storage provider that the volume is the same one.

We should validate that the same name isn't being reused for different volumes for the same plugin, in the RPC handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant