Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ability to watch for events in all data centers #20908

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Ability to watch for events in all data centers #20908

wants to merge 6 commits into from
+247 −18

Conversation

vijayraghav-io
Copy link
Contributor

@vijayraghav-io vijayraghav-io commented Mar 27, 2024 •
edited

Description

fixes #20871

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label Mar 27, 2024
@vijayraghav-io vijayraghav-io changed the title feat: Ability to watch for events in all data centers #20871 feat: Ability to watch for events in all data centers Mar 27, 2024
@vijayraghav-io
Copy link
Contributor Author

vijayraghav-io commented Apr 2, 2024 •
edited

Sample output with -alldatacenters=true (new flag added)

Screenshot 2024-04-03 at 5 58 51 PM

@vijayraghav-io vijayraghav-io marked this pull request as ready for review April 3, 2024 13:50
@vijayraghav-io vijayraghav-io requested a review from a team as a code owner April 3, 2024 13:50
@vijayraghav-io
Copy link
Contributor Author

Hi @david-yu / @jkirschner-hashicorp / @huikang,
Kindly take this PR for review.

FYI @jakubgs

jakubgs
jakubgs approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, looks mostly good, but it seems to me like both RunWithClientAndHclogAllDatacenters and RunWithClientAndHclog are very similar. One could say that one is just a special case of the other. It would probably make more sense to do this with one function that always loops over DCs, and one DC watching is simply a special case of that where the list has just one element.

api/watch/plan.go Show resolved Hide resolved
@vijayraghav-io
Copy link
Contributor Author

Hi @david-yu / @jkirschner-hashicorp / @huikang ,
kindly take this PR for approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
theme/api Relating to the HTTP API interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to watch for events in all data centers
2 participants
@vijayraghav-io @jakubgs