Skip to content

Commit fc47388

Browse files
authored
Improve transport event listener (#2287)
1 parent 46f33d5 commit fc47388

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

lib/PuppeteerSharp/Connection.cs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,18 @@ protected virtual void Dispose(bool disposing)
243243
}
244244

245245
private async void Transport_MessageReceived(object sender, MessageReceivedEventArgs e)
246-
=> await _callbackQueue.Enqueue(() => ProcessMessage(e)).ConfigureAwait(false);
246+
{
247+
try
248+
{
249+
await _callbackQueue.Enqueue(() => ProcessMessage(e)).ConfigureAwait(false);
250+
}
251+
catch (Exception exception)
252+
{
253+
// We could just catch ObjectDisposedException but as this is an event listener
254+
// we don't want to crash the whole process.
255+
_logger.LogError(exception, $"Failed to process message {e.Message}");
256+
}
257+
}
247258

248259
private async Task ProcessMessage(MessageReceivedEventArgs e)
249260
{

lib/PuppeteerSharp/PuppeteerSharp.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
<Description>Headless Browser .NET API</Description>
1313
<PackageId>PuppeteerSharp</PackageId>
1414
<PackageReleaseNotes></PackageReleaseNotes>
15-
<PackageVersion>11.0.0</PackageVersion>
16-
<ReleaseVersion>11.0.0</ReleaseVersion>
17-
<AssemblyVersion>11.0.0</AssemblyVersion>
18-
<FileVersion>11.0.0</FileVersion>
15+
<PackageVersion>11.0.1</PackageVersion>
16+
<ReleaseVersion>11.0.1</ReleaseVersion>
17+
<AssemblyVersion>11.0.1</AssemblyVersion>
18+
<FileVersion>11.0.1</FileVersion>
1919
<SynchReleaseVersion>false</SynchReleaseVersion>
2020
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
2121
<DebugType>embedded</DebugType>

0 commit comments

Comments
 (0)