Skip to content

Commit ea6f4ec

Browse files
authored
Fix chromium latest download (#2307)
1 parent fa82dd1 commit ea6f4ec

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

lib/PuppeteerSharp.Tests/Browsers/Chromium/ChromiumDataTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.IO;
3+
using System.Threading.Tasks;
34
using NUnit.Framework;
45
using PuppeteerSharp.Nunit;
56

@@ -62,5 +63,9 @@ public void ShouldResolveExecutablePath()
6263
BrowserData.Chromium.RelativeExecutablePath(Platform.Win64, "12372323"),
6364
Path.Combine("chrome-win", "chrome.exe"));
6465
}
66+
67+
[Test]
68+
public async Task ShouldResolveBuildIdFromPlatform()
69+
=> Assert.True(int.TryParse(await BrowserData.Chromium.ResolveBuildIdAsync(Platform.MacOSArm64), out var _));
6570
}
6671
}

lib/PuppeteerSharp/BrowserData/JsonUtils.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Net.Http;
33
using System.Threading.Tasks;
44
using Newtonsoft.Json;
@@ -14,10 +14,10 @@ public static async Task<T> GetAsync<T>(string url)
1414
return JsonConvert.DeserializeObject<T>(response);
1515
}
1616

17-
internal static Task<string> GetTextAsync(string url)
17+
internal static async Task<string> GetTextAsync(string url)
1818
{
1919
using var client = new HttpClient();
20-
return client.GetStringAsync(url);
20+
return await client.GetStringAsync(url).ConfigureAwait(false);
2121
}
2222
}
2323
}

lib/PuppeteerSharp/PuppeteerSharp.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
<Description>Headless Browser .NET API</Description>
1313
<PackageId>PuppeteerSharp</PackageId>
1414
<PackageReleaseNotes></PackageReleaseNotes>
15-
<PackageVersion>11.0.4</PackageVersion>
16-
<ReleaseVersion>11.0.4</ReleaseVersion>
17-
<AssemblyVersion>11.0.4</AssemblyVersion>
18-
<FileVersion>11.0.4</FileVersion>
15+
<PackageVersion>11.0.5</PackageVersion>
16+
<ReleaseVersion>11.0.5</ReleaseVersion>
17+
<AssemblyVersion>11.0.5</AssemblyVersion>
18+
<FileVersion>11.0.5</FileVersion>
1919
<SynchReleaseVersion>false</SynchReleaseVersion>
2020
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
2121
<DebugType>embedded</DebugType>

0 commit comments

Comments
 (0)