Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress anotation timeout-server does not change haproxy config #617

Open
dosmanak opened this issue Feb 23, 2024 · 6 comments
Open

ingress anotation timeout-server does not change haproxy config #617

dosmanak opened this issue Feb 23, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@dosmanak
Copy link
Contributor

I added annotation haproxy.org/timeout-server: 15m to ingress manifest but generated backend does not contain timeout server directive.
annotations:

    haproxy.org/backend-config-snippet: http-request deny if !{ path_beg -f patterns/keycloak-publicly-available-urls
      } !{ src -f patterns/whitelisted-ips }
    haproxy.org/forwarded-for: "true"
    haproxy.org/ssl-redirect: "true"
    haproxy.org/timeout-server: 15m

haproxy.cfg backend

backend keycloak-dev_svc-keycloak_http
  mode http
  balance roundrobin
  option forwardfor
  no option abortonclose
  default-server check
  ###_config-snippet_### BEGIN
  http-request deny if !{ path_beg -f patterns/keycloak-publicly-available-urls } !{ src -f patterns/whitelisted-ips }
  ###_config-snippet_### END
  server SRV_1 10.64.142.228:8080 enabled
  server SRV_2 127.0.0.1:8080 disabled
  server SRV_3 127.0.0.1:8080 disabled
  server SRV_4 127.0.0.1:8080 disabled
  server SRV_5 127.0.0.1:8080 disabled
  server SRV_6 127.0.0.1:8080 disabled
  server SRV_7 127.0.0.1:8080 disabled
  server SRV_8 127.0.0.1:8080 disabled

Version is haproxytech/kubernetes-ingress:1.10.7

Copy link

stale bot commented Mar 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 24, 2024
@dosmanak
Copy link
Contributor Author

I read on Slack I am not the only one who experienced the bug.

@stale stale bot removed the stale label Mar 25, 2024
@ivanmatmati
Copy link
Collaborator

Hi @dosmanak , I'm looking at it, thanks for reporting.

@ivanmatmati ivanmatmati self-assigned this Mar 25, 2024
@ivanmatmati
Copy link
Collaborator

It seems the documentation for annotation is not aligned with the code on this because of the possibility of using CRD for that. But as the annotation is present at configmap level, we'll add the missing annotations for ingress and service resources. Thanks for reporting.

@ivanmatmati ivanmatmati added the bug Something isn't working label Mar 25, 2024
@fabianonunes
Copy link
Contributor

Hello, @ivanmatmati

I noticed that this bug isn't reproducible on the 1.11 branch. After bisecting, I found out that commit e2f797c fixes this issue.

Perhaps we should consider backporting it to the 1.10 branch

@ivanmatmati
Copy link
Collaborator

Hi @fabianonunes , you're correct and actually I made a mistake because the version that @dosmanak uses does not provide the annotation for service and ingress. As you noticed only 1.11 does. We'll consider to backport it as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants