Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I know this is an old thread, but chiming in here - because _MSC_VER is defined when clang is building in msvc compatibility mode (via clang-cl), the addition of the changes in 957291343c16aa5d1ef3c54d024957f7316b110f to add [[msvc::flatten]] raises the diagnostic -Wunknown-attributes on clang-cl builds: #279

Open
hanickadot opened this issue Apr 5, 2023 · 0 comments

Comments

@hanickadot
Copy link
Owner

          I know this is an old thread, but chiming in here - because _MSC_VER is defined when clang is building in msvc compatibility mode (via clang-cl), the addition of the changes in 957291343c16aa5d1ef3c54d024957f7316b110f to add `[[msvc::flatten]]` raises the diagnostic `-Wunknown-attributes` on clang-cl builds:
ctre\ctre.hpp(5598,37): fatal error: unknown attribute 'flatten' ignored [-Wunknown-attributes]
template <ctll::fixed_string input> CTRE_FLATTEN constexpr CTRE_FORCE_INLINE auto operator""_ctre() noexcept {
                                    ^~~~~~~~~~~~
ctre\ctre.hpp(1409,24): note: expanded from macro 'CTRE_FLATTEN'
#define CTRE_FLATTEN [[msvc::flatten]]

Originally posted by @remyjette in #172 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant