-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers installed without library prefix/decoration #241
Comments
Hi, you can easily take everything in About unification of namespaces ... I would prefer |
That could work (we wouldn't even need the |
I will change the tests. |
|
Thanks for the offer to change the tests. Regarding |
We are trying to package
ctre
forbuild2
where, in order to allow multiple libraries to co-exist, we have rules a bit stricter than "install whatever you want anywhere you want under/usr/include
". Specifically, we normally require the headers either to be decorated with the library name (or be the library name) or they must be installed into a subdirectory of/usr/include
decorated with the library name (or be the library name). This way we can be reasonably sure that independent libraries won't overwrite each other's headers.Looking at
ctre
, I see a few problems in this area:There is the
unicode-db.hpp
header and theunicode-db/
subdirectory. In fact, this looks like an external library bundled withctre
(@cor3ntin, perhaps it's this one https://github.com/cor3ntin/ext-unicode-db). If that's the case, would it make sense to unbundle it or at least make it possible to unbundle (e.g., by including upstream's headers as-is)? Alternatively, if unbundling is not a good idea, would it be possible to prefix the header/directory withctre
(you would probably also want to prefix the namespace)?Similarly, there is
ctll.hpp
andctll/
. I suppose we can let this one slide (at least it includes half of the library name) but it makes me wonder if this could/should be a separate library (author of issue Packaging of this lib has multiple issues #207 seems to think so).Could someone clarify what's going on here and if there are any plans to address these issues?
The text was updated successfully, but these errors were encountered: