-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Demo page in the docs (replace BigExample, fix iframe-related problems) #9209
Comments
In other words, remove |
There are more problems with the Demo in the Docs that need to be urgently fixed. Most of them were found in https://docs.google.com/spreadsheets/d/15q2Bv4UCIoXLktZDDqSTupTLSSO0BWvoxfJbeUbCauU/edit by @aninde and @krzysztofspilka:
I am removing it from the |
as expressed in the requirement in #9209: - Removing tabs (.row .tab) - Placing links to GitHub below the demo under the header "Find the code on GitHub" - Setting the background to transparent (.bigPreviewExample>div:not(.tab))
* remove BigExample in favor of a simpler iframe as expressed in the requirement in #9209: - Removing tabs (.row .tab) - Placing links to GitHub below the demo under the header "Find the code on GitHub" - Setting the background to transparent (.bigPreviewExample>div:not(.tab)) * change the words "Handsontable's source code" to "a demo of Handsontable" because this is definitely not the source code of Handsontable, just a simple demo of its features Co-authored-by: Jakub Wiśniewski <[email protected]>
The PR #9531 implements the problem expressed in the first message, but not the problems implemented in the later comments. |
I created a new issue to remove IFRAME from the Demo page: https://github.com/handsontable/dev-handsontable/issues/34 Other issues about bugs in Handsontable related to |
shouldn't, is not imported.
Hence most of the above issues are resolved, I'm closing #9209. |
Description
We restored the demo page at https://handsontable.com/docs/demo/ but we need to put finishing touches to it.
We can achieve that by:
Before
After
The text was updated successfully, but these errors were encountered: