Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: when i use 'custom renderer as a component'. Sometimes, the Component Elements will be automatically cleared #10800

Open
FF-zhy opened this issue Feb 22, 2024 · 5 comments
Labels

Comments

@FF-zhy
Copy link

FF-zhy commented Feb 22, 2024

Describe the bug

for example:
after edit one cell, all custom render create Elements will be cleared. (small amount data, the effect can be seen through Chrome DevTools debugger)

if has many custom cells ,there will be a noticeable flicker.

why not updating TD through React render ?

Video/Screenshots

init:
Snipaste_2024-02-22_11-36-02
afterEdit:
Snipaste_2024-02-22_11-22-18

Provide a link to the demo with the bug reproduction

https://codesandbox.io/p/sandbox/declare-a-custom-renderer-as-a-component-d2tnvx?layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clswmu4ht00063j6fey0r64xw%2522%252C%2522sizes%2522%253A%255B70%252C30%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clswmu4hs00023j6f5abnaz1h%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clswmu4hs00033j6fsugv332q%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clswmu4hs00053j6fibf93hpp%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B50%252C50%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clswmu4hs00023j6f5abnaz1h%2522%253A%257B%2522id%2522%253A%2522clswmu4hs00023j6f5abnaz1h%2522%252C%2522tabs%2522%253A%255B%255D%257D%252C%2522clswmu4hs00053j6fibf93hpp%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clswmu4hs00043j6f0m0bgxbu%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522UNASSIGNED_PORT%2522%252C%2522port%2522%253A0%252C%2522path%2522%253A%2522%252F%2522%257D%255D%252C%2522id%2522%253A%2522clswmu4hs00053j6fibf93hpp%2522%252C%2522activeTabId%2522%253A%2522clswmu4hs00043j6f0m0bgxbu%2522%257D%252C%2522clswmu4hs00033j6fsugv332q%2522%253A%257B%2522tabs%2522%253A%255B%255D%252C%2522id%2522%253A%2522clswmu4hs00033j6fsugv332q%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Atrue%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D

Handsontable version

14.1.0

Framework version

@handsontable/react 14.1.0

Your environment

Chrome/121.0.0.0

@FF-zhy FF-zhy added the bug label Feb 22, 2024
@adrianszymanski89
Copy link
Contributor

Hi @FF-zhy

Thank you for reporting this. We are aware of the flickering issue and are currently working on a fix for this. However, I am not able to reproduce the problem with disappearing data.

Can you please share an example where this can be replicated?

@FF-zhy
Copy link
Author

FF-zhy commented Feb 22, 2024

Hi @FF-zhy

Thank you for reporting this. We are aware of the flickering issue and are currently working on a fix for this. However, I am not able to reproduce the problem with disappearing data.

Can you please share an example where this can be replicated?

I did not find any issue with the disappearance of data

@FF-zhy
Copy link
Author

FF-zhy commented Feb 22, 2024

This picture is a screenshot at the debugger breakpoint

@adrianszymanski89
Copy link
Contributor

@FF-zhy

Ok, thank you for the clarification. Then, I will update you once we have the fix ready.

@FF-zhy
Copy link
Author

FF-zhy commented Feb 22, 2024

@adrianszymanski89
Thank YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants