Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of JUnitMatchers #14

Closed
UrsMetz opened this issue Sep 10, 2015 · 2 comments
Closed

Future of JUnitMatchers #14

UrsMetz opened this issue Sep 10, 2015 · 2 comments

Comments

@UrsMetz
Copy link

UrsMetz commented Sep 10, 2015

Almost all factory methods in JUnitMatchers delegate to CoreMatchers from java-hamcrest. There are two matchers left for Throwables (isThrowable and isException) that are not part of hamcrest. The last code usage inside hamcrest-java of JUnitMatchers is removed in #13. There are JavaDoc references in Assume that could easily be changed say that people should use the matchers from java-hamcrest.
I think those two matchers should be moved to hamcrest and JUnitMatchers should be deleted or at least those matchers that only delegate to CoreMatchers should be removed.

@sf105
Copy link
Member

sf105 commented Sep 10, 2015

My plan was to break up JUnitMatchers. You'll see how it was going in the 2.0.0 branch. But I got diverted.

@sf105 sf105 closed this as completed Sep 10, 2015
@UrsMetz
Copy link
Author

UrsMetz commented Sep 10, 2015

@sf105 Do you mean the 2.0.0 branch of JavaHamcrest? I couldn't find a 2.0.0 branch of hamcrest-junit.
I think there is nothing left in JUnitMatchers that should be kept/split up (the only reason would be backward compatibility but I gather that this is not the focus as hamcrest-junit as it is relatively new and is more concerned being a "fresh" and maybe compatibility-breaking replacement of the hamcrest-related parts of JUnit). Most of the factory methods are deprecated anyway and only delegate to Hamcrest matchers.

The only unique stuff are the two Throwablematchers: those could be moved to JavaHamcrest.

Or am I missing some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants