Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorts still show #2

Open
einekratzekatze opened this issue Jun 6, 2023 · 11 comments
Open

Shorts still show #2

einekratzekatze opened this issue Jun 6, 2023 · 11 comments
Assignees

Comments

@einekratzekatze
Copy link

I think YouTube changed something, and now they don't get blocked anymore

@hallzy
Copy link
Owner

hallzy commented Jun 6, 2023

Thanks for reporting, yes looks like the names of the containers changed. I pushed a new update, hopefully that fixes it for you :)

@hallzy hallzy self-assigned this Jun 6, 2023
@einekratzekatze
Copy link
Author

Disabled:
image
Enabled;
image
Does not seem to be fully fixed

@MaxPuig
Copy link

MaxPuig commented Jun 10, 2023

In the case above, I believe the issue is that shorts that are programmed to be released in the future don't get hidden.

I also get a blank space where the shorts were. I don't know if that can be fixed, so it shows as before, like a continuous list of videos.

Thanks for the fix @hallzy

@hallzy
Copy link
Owner

hallzy commented Jun 12, 2023

From the screenshots above, I don't see any actual "shorts', so in that sense it is working as intended.

The short videos that seem to be showing up (like the 10 second one) are technically regular youtube videos and are not "shorts" to youtube. My script checks for the URL of the video to begin with /shorts, so if the video isn't recognized by youtube as a short, my script also won't recognize it as a short.

I could also check the duration of the videos and remove anything less than 60 seconds long, but that might be going too far??? I can't think of many situations where I have come across a regular youtube video that is less than a minute long that I actually wanted to watch, but let me know what you both think...

As for the missing space, looks like YouTube has made some styling changes that makes that happen, which would make it hard for me to fix (If instead of deleting the video element, I delete it's parent, then we will just lose the whole row, which obviously is not what we want.

The only thing that might (might) work, is removing video elements and adding them back in to fill the gaps, but that could get ugly quickly, if it even works at all. So for all intents and purposes, I think I'm going to just have to say that that can't be done.

@hallzy
Copy link
Owner

hallzy commented Jun 12, 2023

Actually, even if I look at the duration, those videos that haven't been released yet (which also aren't technically "shorts") have no duration, so I wouldn't be able to remove those anyways, unless I'm going to just start hiding all videos that haven't released yet as well.

@einekratzekatze
Copy link
Author

Is it not possible to find this tag?:
image
https://github.com/ProbablyRaging/hide-youtube-shorts Seems to work fine. I'd prefer a simple script over an extension, though.
So maybe you could try to figure out what they do differently 🤷

@hallzy
Copy link
Owner

hallzy commented Jun 13, 2023

The image you posted above with the script enabled doesn't have any visible shorts, so as far as I'm concerned, the script is working correctly, and it is removing all the videos with that shorts tag... Unless you are still seeing those but just didn't capture it in the screenshot.

The only issue is the gaps that appear where the shorts were removed, and that is harder to solve with the latest YouTube update.

@Multarix
Copy link

The gap could probably be fixed by shuffling around videos into the correct divs, but it's probably not worth the hassle, especially given youtube itself does that when the size of the screen changes.

Anyway, just wanted to say thanks for making this, I was too lazy to do it myself!

@MaxPuig
Copy link

MaxPuig commented Jun 22, 2023

The problem I have right now is when searching on YouTube. A lot of loading symbols appear, which makes no sense as there aren't that many shorts.
image

@hallzy
Copy link
Owner

hallzy commented Jun 22, 2023

@MaxPuig just updated the script again, so hopefully that goes away now.

Seems like every time I make a change, youtube changes and breaks it, but this should be more fool proof now hopefully.

@MaxPuig
Copy link

MaxPuig commented Jun 22, 2023

Thanks, that fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants