Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author url always broken #248

Open
laran opened this issue Apr 7, 2023 · 3 comments
Open

Author url always broken #248

laran opened this issue Apr 7, 2023 · 3 comments

Comments

@laran
Copy link

laran commented Apr 7, 2023

obsidian-kindle-plugin/src/rendering/templates/bookTemplate.njk

Line 5 in bfef1c0

* Author: [{{author}}]({{authorUrl}})

This line is always returning authorUrls like this:
[Deepak Chopra](https://www.amazon.comundefined)

I would like all my notes to just link to a page for the author like this:
[[Deepak Chopra]]
@hadynz
Copy link
Owner

hadynz commented Apr 7, 2023

Can you give me an example of an Amazon book that results in such a url?

This functionality works. So it must be an issue with a a specific type of books that the plug-in has not catered for.

@laran
Copy link
Author

laran commented Apr 7, 2023

Sure: https://a.co/d/dZ9bK6v

@dosumis
Copy link

dosumis commented Jul 26, 2023

Example of broken Author link:

image

@centerfield77 centerfield77 mentioned this issue Feb 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laran @dosumis @hadynz