Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Store token in safe place like keychain #319

Open
khanhicetea opened this issue Oct 1, 2018 · 3 comments · May be fixed by #321
Open

[Feature Request] Store token in safe place like keychain #319

khanhicetea opened this issue Oct 1, 2018 · 3 comments · May be fixed by #321
Labels
new feature

Comments

@khanhicetea
Copy link

Hi, thanks for creating this awesome app !

Currently, Lepton save Github access token in User Data storage as plain text (macOS : ~/Library/Application\ Support/Lepton/storage/token.json)

Could we store sensitive data inside keychain of OS ?

I recommend using this lib : https://github.com/atom/node-keytar
@hackjutsu
Copy link
Owner

That's a good call! Would you mind sending a PR for that given you have done some research in this area?

@khanhicetea
Copy link
Author

I'm a newbie JS developer. But I will try my best to make a PR for this feature :)

@khanhicetea khanhicetea linked a pull request Oct 2, 2018 that will close this issue
Open
@khanhicetea
Copy link
Author

I made a PR, please help me on review code (sorry for bad code b/c I'm new in JS and Electron) :)

Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[New Feature] Using node-keytar to store github token in safe place khanhicetea/Lepton
2 participants
@khanhicetea @hackjutsu