chore: enforce typing import ban with lint rule

We now use ruff/flake8-tidy-imports to ban importing
typing/typing_extensions. Unfortunately it doesn't seem to support
banning everything except allow-listed items, so we have to ignore
places that need to import Literal and overload from typing (due to ruff
mis-handling them when they're imported from our typing module).

Author: h4l

pyproject.toml

@@ -87,6 +87,7 @@ select = [
   "FA",  # flake8-future-annotations
   "PYI", # flake8-pyi
   "I",
+  "TID", # flake8-tidy-imports
 ]
 
 ignore = [
@@ -102,6 +103,10 @@ ignore = [
   "PYI041",
 ]
 
+[tool.ruff.lint.flake8-tidy-imports.banned-api]
+"typing_extensions".msg = "use denokv._pycompat.typing instead, typing_extensions is not a runtime dependency."
+"typing".msg = "Use denokv._pycompat.typing instead (apart from overload and Literal), using typing is error-prone as it has many differences between python versions."
+
 [tool.ruff.lint.pydocstyle]
 convention = "numpy"
 

src/denokv/_kv_writes.py

@@ -9,8 +9,8 @@
 from functools import total_ordering
 from itertools import islice
 from types import MappingProxyType
-from typing import Literal
-from typing import overload
+from typing import Literal  # noqa: TID251
+from typing import overload  # noqa: TID251
 
 from v8serialize import Encoder
 from v8serialize.constants import FLOAT64_SAFE_INT_RANGE

src/denokv/_pycompat/dataclasses.py

@@ -4,8 +4,10 @@
 from dataclasses import FrozenInstanceError
 from dataclasses import dataclass
 from dataclasses import fields as dataclass_fields
-from typing import Literal
-from typing import TypedDict  # avoid circular reference with _pycompat.typing
+from typing import Literal  # noqa: TID251
+
+# avoid circular reference with _pycompat.typing
+from typing import TypedDict  # noqa: TID251
 
 
 class NoArg(TypedDict):

src/denokv/_pycompat/protobuf.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import overload
+from typing import overload  # noqa: TID251
 
 from denokv._datapath_pb2 import AtomicWriteStatus
 from denokv._datapath_pb2 import MutationType

src/denokv/_pycompat/types.py

@@ -1,5 +1,5 @@
 from enum import Enum
-from typing import Literal
+from typing import Literal  # noqa: TID251
 
 from denokv._pycompat.typing import TypeAlias
 

src/denokv/_pycompat/typing.py

@@ -6,6 +6,8 @@
 without needing if TYPE_CHECKING everywhere.
 """
 
+# ruff: noqa: TID251
+
 from __future__ import annotations
 
 from dataclasses import dataclass

src/denokv/backoff.py

@@ -6,7 +6,7 @@
 from dataclasses import dataclass
 from enum import IntEnum
 from itertools import count
-from typing import Literal
+from typing import Literal  # noqa: TID251
 
 from denokv._pycompat.typing import Callable
 from denokv._pycompat.typing import Iterable

src/denokv/datapath.py

@@ -9,7 +9,7 @@
 from dataclasses import dataclass
 from enum import Enum
 from enum import auto
-from typing import overload
+from typing import overload  # noqa: TID251
 
 import aiohttp
 import aiohttp.client_exceptions

src/denokv/kv.py

@@ -12,8 +12,8 @@
 from functools import partial
 from os import environ
 from types import TracebackType
-from typing import Literal
-from typing import overload
+from typing import Literal  # noqa: TID251
+from typing import overload  # noqa: TID251
 
 import aiohttp
 import v8serialize

src/denokv/kv_keys.py

@@ -4,7 +4,7 @@
 import sys
 from dataclasses import dataclass
 from dataclasses import field
-from typing import overload
+from typing import overload  # noqa: TID251
 
 from fdb.tuple import pack
 from fdb.tuple import unpack