Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptools as run-time dependency #5738

Open
mpg640 opened this issue Aug 2, 2024 · 0 comments · May be fixed by #5740
Open

setuptools as run-time dependency #5738

mpg640 opened this issue Aug 2, 2024 · 0 comments · May be fixed by #5740

Comments

@mpg640
Copy link

mpg640 commented Aug 2, 2024

setuptools is not declared as a run-time dependency here:

sparkling-water/py/src/pyproject.toml

Line 12 in 1a0a318

dependencies = [

Same with the setup.py:

sparkling-water/py/src/setup.py

Line 40 in 1a0a318

# run-time dependencies

Currently, it is only listed as a build dependency in both. However, the following line is run when sparkling-water is imported in Python

sparkling-water/py-scoring/src/ai/h2o/sparkling/Initializer.py

Line 195 in 1a0a318

import pkg_resources as pkg

Note: starting in Python 3.12, setuptools does not come with a venv anymore by default
@hutch3232 hutch3232 linked a pull request Sep 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5738 hutch3232/sparkling-water
1 participant
@mpg640