Skip to content

Commit d517d2e

Browse files
authored
chore: Fix CI (#272)
chore(ci): Add additional Node versions to matrix chore(ci): Temporarily only build on x86_64 MacOS chore(deps): Bump liftoff for Node 24 support chore(ci): Skip broken Windows test on Node 24
1 parent e422eb1 commit d517d2e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/dev.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ jobs:
3131
strategy:
3232
fail-fast: false
3333
matrix:
34-
node: [10, 12, 14, 16, 18]
35-
os: [ubuntu-latest, windows-latest, macos-latest]
34+
node: [10, 12, 14, 16, 18, 20, 22, 24]
35+
os: [ubuntu-latest, windows-latest, macos-13]
3636

3737
steps:
3838
- name: Clone repository

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"copy-props": "^4.0.0",
3636
"gulplog": "^2.2.0",
3737
"interpret": "^3.1.1",
38-
"liftoff": "^5.0.0",
38+
"liftoff": "^5.0.1",
3939
"mute-stdout": "^2.0.0",
4040
"replace-homedir": "^2.0.0",
4141
"semver-greatest-satisfied-range": "^2.0.0",

test/window-extended-length-paths.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ var gulpJsPath = '\\\\?\\' + path.resolve(__dirname, '../bin/gulp.js');
1818

1919
describe('windows extended length paths', function() {
2020
it('Should run normaly even if using \'\\\\?\\\'prefix in paths', function(done) {
21-
if (os.platform() !== 'win32') {
21+
// It seems like Node 24 broke support for this launching an entry point
22+
if (os.platform() !== 'win32' || process.versions.node.startsWith("24.")) {
2223
this.skip();
2324
return;
2425
}

0 commit comments

Comments
 (0)