Only raise double click in same pos

Author: tznind

Terminal.Gui/ConsoleDrivers/V2/MouseButtonState.cs

@@ -10,6 +10,7 @@ internal class MouseButtonStateEx
     private readonly TimeSpan _repeatClickThreshold;
     private readonly int _buttonIdx;
     private int _consecutiveClicks;
+    private Point _lastPosition = new Point ();
 
     /// <summary>
     ///     When the button entered its current state.
@@ -31,10 +32,11 @@ public MouseButtonStateEx (Func<DateTime> now, TimeSpan repeatClickThreshold, in
     public void UpdateState (MouseEventArgs e, out int? numClicks)
     {
         bool isPressedNow = IsPressed (_buttonIdx, e.Flags);
+        bool isSamePosition = _lastPosition == e.Position;
 
         TimeSpan elapsed = _now () - At;
 
-        if (elapsed > _repeatClickThreshold)
+        if (elapsed > _repeatClickThreshold || !isSamePosition)
         {
             // Expired
             OverwriteState (e);
@@ -70,6 +72,7 @@ private void OverwriteState (MouseEventArgs e)
     {
         Pressed = IsPressed (_buttonIdx, e.Flags);
         At = _now ();
+        _lastPosition = e.Position;
     }
 
     private bool IsPressed (int btn, MouseFlags eFlags)

UnitTests/ConsoleDrivers/V2/MouseInterpreterTests.cs

@@ -35,50 +35,47 @@ public static IEnumerable<object []> SequenceTests ()
     {
         yield return new object []
         {
-            new List<MouseEventArgs> ()
+            new List<MouseEventArgs>
             {
-                // Mouse was down
-                new ()
-                {
-                    Flags = MouseFlags.Button1Pressed
-                },
-
-                // Then it wasn't
+                new() { Flags = MouseFlags.Button1Pressed },
                 new()
             },
-            // No extra then click
             null,
             MouseFlags.Button1Clicked
         };
 
         yield return new object []
         {
-            new List<MouseEventArgs> ()
+            new List<MouseEventArgs>
             {
-                // Mouse was down
-                new ()
-                {
-                    Flags = MouseFlags.Button1Pressed
-                },
-
-                // Then it wasn't
+                new() { Flags = MouseFlags.Button1Pressed },
                 new(),
-
-                // Then it was again
-                new ()
-                {
-                    Flags = MouseFlags.Button1Pressed
-                },
-
-                // Then it wasn't
+                new() { Flags = MouseFlags.Button1Pressed },
                 new()
             },
-            // No extra then click, then into none/double click
             null,
             MouseFlags.Button1Clicked,
             null,
             MouseFlags.Button1DoubleClicked
         };
+
+
+        yield return new object []
+        {
+            new List<MouseEventArgs>
+            {
+                new() { Flags = MouseFlags.Button1Pressed ,Position = new Point (10,11)},
+                new(){Position = new Point (10,11)},
+
+                // Clicking the line below means no double click because it's a different location
+                new() { Flags = MouseFlags.Button1Pressed,Position = new Point (10,12) },
+                new(){Position = new Point (10,12)}
+            },
+            null,
+            MouseFlags.Button1Clicked,
+            null,
+            MouseFlags.Button1Clicked //release is click because new position
+        };
     }
 
 }