Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeforeTransition hook to control options dynamically #17

Open
FransTwisk opened this issue Apr 18, 2019 · 1 comment
Open

BeforeTransition hook to control options dynamically #17

FransTwisk opened this issue Apr 18, 2019 · 1 comment

Comments

@FransTwisk
Copy link

FransTwisk commented Apr 18, 2019

I'm using this mixin in a global layout animating the content between route changes and such and it works very well for this. However, sometimes the difference in height between one route and the next is a lot, causing a weird (long) animation.

It would be great if there was a beforeTransition hook where start and end properties are available (in this case height before and after) and a way to dynamically change the options in that hook for that run.

For instance, if the difference in height would be more then a certain amount, we disable the transition for that particular run. I'm sure this will also be useful for a lot of other use cases!

@FransTwisk FransTwisk changed the title Before/after hook to control options BeforeTransition hook to control options dynamically Apr 18, 2019
@FransTwisk
Copy link
Author

I've created a (simple) merge request for this. #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant