Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit animation jumps when using Vue <group-transitions> #14

Open
rolfo85 opened this issue Dec 6, 2018 · 10 comments
Open

Exit animation jumps when using Vue <group-transitions> #14

rolfo85 opened this issue Dec 6, 2018 · 10 comments

Comments

@rolfo85
Copy link

rolfo85 commented Dec 6, 2018

Hello,

I've been looking for something like this plugin for a very long time. It is absolutely amazing!!! please keep supporting it.

However I encountered a couple of issues.

Using group-transitions with a simple fade effect to show the content, the outer container animates its height properly when the content is entering, but when it fades away, the outer container starts animating properly but then it suddenly stops and jumps all the way to height 0 with no transition.

I created a sandbox that replicates the bug.
https://codesandbox.io/s/ry50n8vwnn

Another note:
The plugin seems not working when used together with animate.css within Vue transitions.
But that is another bug I guess, so eventually I will open another issue.

Thanks!

@rolfo85 rolfo85 changed the title Jumping closing animation using Vue <group-transitions> Exit animation jumps when using Vue <group-transitions> Dec 6, 2018
@guanzo
Copy link
Owner

guanzo commented Dec 6, 2018

Will investigate after work, thanks for making an issue.

@guanzo
Copy link
Owner

guanzo commented Dec 7, 2018

Can I ask why you're using a <transition-group> for elements that transition out at the same time? Why not just use <transition>? Like this: https://codesandbox.io/s/82j698xpx0

@rolfo85
Copy link
Author

rolfo85 commented Dec 7, 2018

Hey,

Yes you're right. In that case it doesn't make sense using transition group. I updated my example with a for loop where you are supposed to use the transition-group.

https://codesandbox.io/s/ry50n8vwnn

It's not the case now, but I'm planning to use this plugin for a large project and I was trying to test it in all the conditions to have an idea of what I'm going to face. But again, it's amazing man!

@rolfo85
Copy link
Author

rolfo85 commented Dec 13, 2018

did you have any chance to fix it with group-transitions?

@guanzo
Copy link
Owner

guanzo commented Dec 14, 2018

It's on my todo list. Will get around to it!

@chasegiunta
Copy link

Running into this today! Is this not already present on the demo page? Or is this a different issue?
transition-group

@guanzo
Copy link
Owner

guanzo commented Jan 21, 2019

Which browser is that gif from?

This is a different issue, and one that should already be working normally, unless you're using a minority browser.

@chasegiunta
Copy link

@guanzo Latest Chrome, I think (71.0.3578.98) . Also happens on Safari (Mac - Version 12.0.2)

@chasegiunta
Copy link

Hmm, that issue in the .gif might be a mounting issue / race condition (separate issue). If I toggle VSR off and back on again, or even toggle dev tools, it works as expected.

@hyvyys
Copy link

hyvyys commented Sep 26, 2019

https://recordit.co/8b6msaALDa

I've got a problem here using nested SmoothReflow components. It appears that the initial height for the transition is calculated incorrectly, it is too small when height is growing and too great when height is shrinking.

https://recordit.co/BF06xbOCso In this video, I removed all the transition-groups, and the smooth reflow stopped working, it only starts working after I remove some items from the second panel, and it still only works for adding items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants