Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link action-button in org-mode files creates HTML link #2527

Open
4 tasks done
mmarshall540 opened this issue Feb 13, 2025 · 2 comments · May be fixed by #2528
Open
4 tasks done

Link action-button in org-mode files creates HTML link #2527

mmarshall540 opened this issue Feb 13, 2025 · 2 comments · May be fixed by #2528

Comments

@mmarshall540
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Greetings, I love this app. Thank you for creating it and for merging support for the OrgMode markup format.

When editing a file in Org format, the action-link button for inserting a link inserts an HTML link, instead of an Org-mode link, even though Markor's Viewer is able to recognize and follow preexisting (or manually-inserted) Org-mode links. The HTML link is not recognized as a link by Markor's Viewer when viewing an Org file.

Org-mode's link format looks like this:

[[LINK-URL-OR-FILENAME][DESCRIPTION]]

Optionally, the description may be omitted, as shown here:

[[LINK-URL-OR-FILENAME]]

The link format is further described here.

Steps to reproduce

  1. Create or open an Org-mode file in Markor's editor.
  2. Tap the insert-link action-button.
  3. Select a file using the "Browse Filesystem" button.
  4. Tap OK.

Information

Android version: 14
Device: Pixel 8a
App Version: 2.14.0

Source

F-Droid

Format / File type

Something else (-> Additional info)

Additional info / Log

- OrgMode
@harshad1
Copy link
Collaborator

harshad1 commented Feb 13, 2025

whomever maintains org mode needs to extend this:

https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/markor/frontend/AttachLinkOrFileDialog.java#L65

@mmarshall540
Copy link
Author

@harshad1 thank you for pointing me to the right location!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants