Improvements to newfile dialog, open links, other fixes #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
harshad1
commented
May 5, 2024
harshad1
commented
May 5, 2024
harshad1
commented
May 5, 2024
app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java
Show resolved
Hide resolved
harshad1
commented
May 5, 2024
app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java
Show resolved
Hide resolved
harshad1
commented
May 5, 2024
harshad1
commented
May 5, 2024
harshad1
commented
May 5, 2024
harshad1
commented
May 5, 2024
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserListAdapter.java
Outdated
Show resolved
Hide resolved
harshad1
commented
May 5, 2024
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserOptions.java
Outdated
Show resolved
Hide resolved
harshad1
commented
May 10, 2024
app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java
Show resolved
Hide resolved
harshad1
commented
May 10, 2024
harshad1
changed the title
This was
linked to
issues
May 12, 2024
4 tasks
gsantner
reviewed
May 12, 2024
|
|
||
| public static class Format { | ||
| public final @StringRes int format, name; | ||
| public final String ext; |
There was a problem hiding this comment.
Suggestion please make ext / it's handling as regex instead
There was a problem hiding this comment.
These are just meant to be a source of truth, not used for matching etc. i.e. this says ' The canonical extension for markdown is ".md" '
Format and FORMATS is not meant to match or detect formats - that is left to the isFileOutOfThisFormat as before.
gsantner
reviewed
May 12, 2024
gsantner
reviewed
May 12, 2024
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserFragment.java
Outdated
Show resolved
Hide resolved
harshad1
commented
May 13, 2024
| @@ -19,7 +20,7 @@ public class TodoTxtAutoTextFormatter implements InputFilter { | |||
| @Override | |||
| public CharSequence filter(CharSequence source, int start, int end, Spanned dest, int dstart, int dend) { | |||
| try { | |||
| if (start < source.length() && dstart <= dest.length() && TextViewUtils.isNewLine(source, start, end)) { | |||
There was a problem hiding this comment.
Moved some functions from TextViewUtils to GsTextUtils
harshad1
commented
May 13, 2024
| @@ -119,6 +121,8 @@ public static class Options { | |||
|
|
|||
| public Collection<File> favouriteFiles, recentFiles, popularFiles = null; | |||
| public GsCallback.a1<CharSequence> setTitle = null, setSubtitle = null; | |||
|
|
|||
| public GsCallback.a0 refresh = null; | |||
There was a problem hiding this comment.
Reverted back to just having collections and added a refresh callback here. The refresh callback is called in loadFolder() and can be used to do whatever.
harshad1
commented
May 13, 2024
| opts.recentFiles = appSettings.getRecentFiles(); | ||
| opts.popularFiles = appSettings.getPopularFiles(); | ||
| }; | ||
| opts.refresh.callback(); |
There was a problem hiding this comment.
Setting the refresh callback to update sorting, fav file lists etc etc.
|
Broke a few things -> #2297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added the ability to format at new file title similarly to how we format snippets.
Additionally, we now remember template and name format per file type.
This should
yyyyMMddHHmmSS)EDIT:
I have merged in my open links in tags PR so more things have been pulled in here: