Skip to content

Retry middleware ignores the context.CancelFunc returned by context.WithTimeout #203

Open
@silverspace

Description

@silverspace

The go-grpc-middleware retry middleware has a function perCallContext that calls context.WithTimeout and ignores the returned cancel function. According to the context.WithTimeout docs:

// Canceling this context releases resources associated with it, so code should
// call cancel as soon as the operations running in this Context complete:
//
// func slowOperationWithTimeout(ctx context.Context) (Result, error) {
// ctx, cancel := context.WithTimeout(ctx, 100*time.Millisecond)
// defer cancel() // releases resources if slowOperation completes before timeout elapses
// return slowOperation(ctx)
// }

Here is the offending code in https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/retry/retry.go#L290

func perCallContext(parentCtx context.Context, callOpts *options, attempt uint) context.Context {
	ctx := parentCtx
	if callOpts.perCallTimeout != 0 {
		ctx, _ = context.WithTimeout(ctx, callOpts.perCallTimeout)
	}
        ...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions