Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanently record how many comments Discord has made #97

Open
openjck opened this issue Jul 8, 2015 · 8 comments
Open

Permanently record how many comments Discord has made #97

openjck opened this issue Jul 8, 2015 · 8 comments

Comments

@openjck
Copy link
Contributor

openjck commented Jul 8, 2015

No description provided.

@openjck openjck modified the milestone: MVP #1 Jul 8, 2015
@openjck openjck changed the title Record how many comments Discord has made Permanently record how many comments Discord has made Jul 8, 2015
@groovecoder groovecoder self-assigned this Jan 20, 2016
groovecoder added a commit that referenced this issue Jan 20, 2016
@groovecoder
Copy link
Owner

I started this here: 5a0c926

But when I try to run tests, I get:

lcrouch:discord lcrouch$ npm test

> Discord@ test /Users/lcrouch/code/discord
> ./gulp test

[14:05:00] Using gulpfile ~/code/discord/gulpfile.js
[14:05:00] Starting 'test:jshint'...
[14:05:00] Starting 'build:migrate'...
[14:05:00] Starting 'build:readme-html'...
[14:05:01] Finished 'build:readme-html' after 1.14 s
[14:05:04] Finished 'build:migrate' after 3.37 s
[14:05:04] Starting 'build'...
[14:05:04] Finished 'build' after 25 μs
[14:05:04] Finished 'test:jshint' after 4.35 s
[14:05:04] Starting 'test:mocha'...
[14:05:05] Finished 'test:mocha' after 95 ms
[14:05:05] Starting 'test'...
[14:05:05] Finished 'test' after 5.2 μs


npm ERR! Test failed.  See above for more details.

I.e., ERR on the tests, but no details? 😢

@openjck
Copy link
Contributor Author

openjck commented Jan 20, 2016

We talked about this on IRC, but just for the record...

I'm surprised that the tests didn't provide any more details. But as far as the cause, it may be that redis-server and postgres aren't being run. The testing documentation has more info.

@Faeranne
Copy link
Contributor

May be time to use a more advanced test system. coughcough_docker_cough

@groovecoder
Copy link
Owner

Add-more-tooling-as-solution haiku ...

problem with test tools
add another tool on top
new problem on top

@groovecoder
Copy link
Owner

FWIW, I ran with mocha directly and got:

lcrouch:discord lcrouch$ mocha tests/tests.js


[error] Port 3000 is already in use

Do we need to run the tests via gulp? What's the value? It introduces a layer of mis-direction for stuff like this.

@groovecoder
Copy link
Owner

Oh, and when I shut down my gulp run process, the tests ran fine.

Maybe the test task can run on a different port than gulp run does?

@openjck
Copy link
Contributor Author

openjck commented Jan 21, 2016

Yep, exactly. The tests start the application on its default port. If the application is already running in another window there will be a conflict. +1 for having tests start the application on a different port.

One thing I like about Gulp is that it's a single point of entry for development tasks. To do x, run gulp x. We don't have to remember the name of the tool that does the task and can switch it without changing the documentation.

@groovecoder
Copy link
Owner

Yeah, I like it too. It's kinda like tox for python ... sometimes it gets in the way (like this), but overall saves more time than it takes.

groovecoder added a commit that referenced this issue Jan 21, 2016
@groovecoder groovecoder removed their assignment Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants