-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List component children not working with React 18 and typescript #6836
Labels
hacktoberfest
PRs submitted in October (open-source celebration month)
help wanted
Would appreciate community help working on this
typescript
Typescript enhancements and bugs
Comments
AntoLC
changed the title
List component problem with React 18 and typescript
List component children not working with React 18 and typescript
Jun 8, 2023
AntoLC
added a commit
to openfun/marsha
that referenced
this issue
Jun 8, 2023
The children prop of the List component from grommet is not typed correctly. An issue has been open on their repo: grommet/grommet#6836 Here is a quick fix for the time being.
AntoLC
added a commit
to openfun/marsha
that referenced
this issue
Jun 8, 2023
The children prop of the List component from grommet is not typed correctly. An issue has been open on their repo: grommet/grommet#6836 Here is a quick fix for the time being.
AntoLC
added a commit
to openfun/marsha
that referenced
this issue
Jun 9, 2023
The children prop of the List component from grommet is not typed correctly. An issue has been open on their repo: grommet/grommet#6836 Here is a quick fix for the time being.
Thanks for reporting, I think the type for |
AntoLC
added a commit
to openfun/marsha
that referenced
this issue
Jun 13, 2023
The children prop of the List component from grommet is not typed correctly. An issue has been open on their repo: grommet/grommet#6836 Here is a quick fix for the time being.
AntoLC
added a commit
to openfun/marsha
that referenced
this issue
Jun 14, 2023
The children prop of the List component from grommet is not typed correctly. An issue has been open on their repo: grommet/grommet#6836 Here is a quick fix for the time being.
@AntoLC Thank you so much for providing your workaround, it works for us! 🙏 |
jcfilben
added
the
hacktoberfest
PRs submitted in October (open-source celebration month)
label
Sep 19, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hacktoberfest
PRs submitted in October (open-source celebration month)
help wanted
Would appreciate community help working on this
typescript
Typescript enhancements and bugs
Actual Behavior
On the component
<List />
, the children ts interface is not correct with React 18, the code doesn't work.Codepen exhibiting the issue
See by yourself on codesandbox.
The text was updated successfully, but these errors were encountered: