From cfb750f96660cea16799cf497d161df34d8c017e Mon Sep 17 00:00:00 2001
From: Ake Hedman <akhe@grodansparadis.com>
Date: Thu, 16 Nov 2023 18:21:04 +0100
Subject: [PATCH] Secured some string references that was not const

---
 src/vscp/common/mdf.cpp |  14 ++--
 src/vscp/common/mdf.h   | 148 ++++++++++++++++++++--------------------
 2 files changed, 83 insertions(+), 79 deletions(-)

diff --git a/src/vscp/common/mdf.cpp b/src/vscp/common/mdf.cpp
index 1d0fbaa76..9732b5c87 100644
--- a/src/vscp/common/mdf.cpp
+++ b/src/vscp/common/mdf.cpp
@@ -1407,7 +1407,7 @@ write_data(void *ptr, size_t size, size_t nmemb, FILE *stream)
 }
 
 CURLcode
-CMDF::downLoadMDF(std::string &url, std::string &tempFileName)
+CMDF::downLoadMDF(const std::string &url, const std::string &tempFileName)
 {
   CURL *curl;
   FILE *fp;
@@ -1433,9 +1433,10 @@ CMDF::downLoadMDF(std::string &url, std::string &tempFileName)
 //
 
 bool
-CMDF::load(std::string &remoteFile, bool bLocalFile)
+CMDF::load(const std::string &file, bool bLocalFile)
 {
-  std::string localFile = remoteFile;
+  std::string remoteFile = file;
+  std::string localFile = file;
 
   if (remoteFile.npos == remoteFile.find("http://")) {
     std::string str;
@@ -7699,10 +7700,11 @@ CMDF::getDefaultRegisterValue(uint32_t reg, uint16_t page)
 //
 
 CMDF_RemoteVariable *
-CMDF::getRemoteVariable(std::string name)
+CMDF::getRemoteVariable(const std::string& name)
 {
-  vscp_trim(name);
-  vscp_makeLower(name);
+  std::string remotevar = name;
+  vscp_trim(remotevar);
+  vscp_makeLower(remotevar);
 
   std::deque<CMDF_RemoteVariable *>::iterator iter;
   for (iter = m_list_remotevar.begin(); iter != m_list_remotevar.end(); ++iter) {
diff --git a/src/vscp/common/mdf.h b/src/vscp/common/mdf.h
index 7e70f1e1b..89cefc27e 100644
--- a/src/vscp/common/mdf.h
+++ b/src/vscp/common/mdf.h
@@ -106,8 +106,10 @@ typedef enum mdf_record_type {
   mdf_type_mdf_item,
   mdf_type_value,
   mdf_type_value_item,
+  mdf_type_value_sub_item,
   mdf_type_bit,
   mdf_type_bit_item,
+  mdf_type_bit_sub_item,
   mdf_type_register,
   mdf_type_register_item,
   mdf_type_register_sub_item,
@@ -239,7 +241,7 @@ class CMDF_Value : public CMDF_Object {
     Set value name
     @param name Value name to set
   */
-  void setName(std::string &name) { m_name = name; };
+  void setName(const std::string &name) { m_name = name; };
 
   /*!
     Get value
@@ -251,7 +253,7 @@ class CMDF_Value : public CMDF_Object {
     Set value
     @param value Value on string form.
   */
-  void setValue(std::string value) { m_strValue = value; };
+  void setValue(const std::string& value) { m_strValue = value; };
 
   /*!
     Set value
@@ -269,14 +271,14 @@ class CMDF_Value : public CMDF_Object {
     Get the value description
     @return Value description
   */
-  std::string getDescription(std::string lang = "en") { return m_mapDescription[lang]; };
+  std::string getDescription(const std::string lang = "en") { return m_mapDescription[lang]; };
 
   /*!
     Set value description
     @param lang Language
     @param desc Register description to set
   */
-  void setDescription(std::string lang, std::string &desc) { m_mapDescription[lang] = desc; };
+  void setDescription(const std::string& lang, std::string &desc) { m_mapDescription[lang] = desc; };
 
   /*!
     Get the value info URL
@@ -351,7 +353,7 @@ class CMDF_Bit : public CMDF_Object {
     Set bit array name
     @return Set array name
   */
-  void setName(std::string &name) { m_name = name; };
+  void setName(const std::string &name) { m_name = name; };
 
   /*!
     Get the bit description
@@ -377,7 +379,7 @@ class CMDF_Bit : public CMDF_Object {
     @param lang Language
     @param url bit info URL to set
   */
-  void setInfoURL(std::string &lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string &lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -554,7 +556,7 @@ class CMDF_Register : public CMDF_Object {
     Get the register info URL
     @return Register info URL
   */
-  std::string getInfoURL(std::string lang = "en") { return m_mapInfoURL[lang]; };
+  std::string getInfoURL(const std::string lang = "en") { return m_mapInfoURL[lang]; };
 
   /*!
     Set register info URL
@@ -831,20 +833,20 @@ class CMDF_RemoteVariable : public CMDF_Object {
     Set name of the remote variable
     @param name Name of the remote variable
   */
-  void setName(std::string name) { m_name = name; };
+  void setName(const std::string &name) { m_name = name; };
 
   /*!
     Get the register description
     @return Register description
   */
-  std::string getDescription(std::string lang = "en") { return m_mapDescription[lang]; };
+  std::string getDescription(const std::string& lang = "en") { return m_mapDescription[lang]; };
 
   /*!
     Set register description
     @param lang Language
     @param desc Register description to set
   */
-  void setDescription(std::string &lang, std::string &desc) { m_mapDescription[lang] = desc; };
+  void setDescription(const std::string &lang, const std::string &desc) { m_mapDescription[lang] = desc; };
 
   /*!
     Get the register info URL
@@ -857,7 +859,7 @@ class CMDF_RemoteVariable : public CMDF_Object {
     @param lang Language
     @param url Register info URL to set
   */
-  void setInfoURL(std::string &lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string &lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -906,7 +908,7 @@ class CMDF_RemoteVariable : public CMDF_Object {
     Set default value for remote variable
     @param strDefault Default value.
   */
-  void setDefault(std::string strDefault) { m_strDefault = strDefault; };
+  void setDefault(const std::string& strDefault) { m_strDefault = strDefault; };
 
   /*!
     Get Page for remote variable
@@ -1053,7 +1055,7 @@ class CMDF_ActionParameter : public CMDF_Object {
   /*!
     set Name for action
   */
-  void setName(std::string name) { m_name = name; };
+  void setName(const std::string &name) { m_name = name; };
 
   /*!
     Get the register description
@@ -1066,7 +1068,7 @@ class CMDF_ActionParameter : public CMDF_Object {
     @param lang Language
     @param desc Register description to set
   */
-  void setDescription(std::string &lang, std::string &desc) { m_mapDescription[lang] = desc; };
+  void setDescription(const std::string &lang, const std::string &desc) { m_mapDescription[lang] = desc; };
 
   /*!
     Get the register info URL
@@ -1079,7 +1081,7 @@ class CMDF_ActionParameter : public CMDF_Object {
     @param lang Language
     @param url Register info URL to set
   */
-  void setInfoURL(std::string &lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string &lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -1191,20 +1193,20 @@ class CMDF_Action : public CMDF_Object {
   /*!
     set Name for action
   */
-  void setName(std::string name) { m_name = name; };
+  void setName(const std::string &name) { m_name = name; };
 
   /*!
     Get the register description
     @return Register description
   */
-  std::string getDescription(std::string lang = "en") { return m_mapDescription[lang]; };
+  std::string getDescription(const std::string& lang = "en") { return m_mapDescription[lang]; };
 
   /*!
     Set register description
     @param lang Language
     @param desc Register description to set
   */
-  void setDescription(std::string &lang, std::string &desc) { m_mapDescription[lang] = desc; };
+  void setDescription(const std::string &lang, const std::string &desc) { m_mapDescription[lang] = desc; };
 
   /*!
     Get the register info URL
@@ -1217,7 +1219,7 @@ class CMDF_Action : public CMDF_Object {
     @param lang Language
     @param url Register info URL to set
   */
-  void setInfoURL(std::string &lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string &lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -1420,7 +1422,7 @@ class CMDF_EventData : public CMDF_Object {
     @param lang Language
     @param desc Register description to set
   */
-  void setDescription(std::string &lang, std::string &desc) { m_mapDescription[lang] = desc; };
+  void setDescription(const std::string &lang, const std::string &desc) { m_mapDescription[lang] = desc; };
 
   /*!
     Get the register info URL
@@ -1433,7 +1435,7 @@ class CMDF_EventData : public CMDF_Object {
     @param lang Language
     @param url Register info URL to set
   */
-  void setInfoURL(std::string &lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string &lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -1519,7 +1521,7 @@ class CMDF_Event : public CMDF_Object {
   /*!
     Set event name
   */
-  void setName(std::string &name) { m_name = name; };
+  void setName(const std::string &name) { m_name = name; };
 
   /*!
     Get event class
@@ -1580,7 +1582,7 @@ class CMDF_Event : public CMDF_Object {
     @param lang Language
     @param desc Event description to set
   */
-  void setDescription(std::string &lang, std::string &desc) { m_mapDescription[lang] = desc; };
+  void setDescription(const std::string &lang, const std::string &desc) { m_mapDescription[lang] = desc; };
 
   /*!
     Get the event info URL
@@ -1593,7 +1595,7 @@ class CMDF_Event : public CMDF_Object {
     @param lang Language
     @param url Event info URL to set
   */
-  void setInfoURL(std::string &lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string &lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -1666,7 +1668,7 @@ class CMDF_Item : public CMDF_Object {
     Set item value
     @param Value to set
   */
-  void setValue(std::string &str) { m_value = str; };
+  void setValue(const std::string &str) { m_value = str; };
 
   /*!
     Get the register description
@@ -1679,7 +1681,7 @@ class CMDF_Item : public CMDF_Object {
     @param lang Language
     @param desc Register description to set
   */
-  void setDescription(std::string &lang, std::string &desc) { m_mapDescription[lang] = desc; };
+  void setDescription(const std::string &lang, const std::string &desc) { m_mapDescription[lang] = desc; };
 
   /*!
     Get the register info URL
@@ -1692,7 +1694,7 @@ class CMDF_Item : public CMDF_Object {
     @param lang Language
     @param url Register info URL to set
   */
-  void setInfoURL(std::string &lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string &lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -1935,10 +1937,10 @@ class CMDF_Manufacturer : public CMDF_Object {
   void clearStorage(void);
 
   /// Get company name
-  std::string &getName(void) { return m_strName; };
+  std::string getName(void) { return m_strName; };
 
   /// Set company name
-  void setName(const std::string name) { m_strName = name; };
+  void setName(const std::string &name) { m_strName = name; };
 
   /// Get address object
   CMDF_Address *getAddressObj(void) { return &m_address; };
@@ -2083,7 +2085,7 @@ class CMDF_Picture : public CMDF_Object {
     Set name of picture
     @param strURL name
   */
-  void setName(std::string &name) { m_strName = name; };
+  void setName(const std::string &name) { m_strName = name; };
 
   /*!
     Get URL for picture
@@ -2095,7 +2097,7 @@ class CMDF_Picture : public CMDF_Object {
     Set URL for picture
     @param strURL URL for picture
   */
-  void setUrl(std::string &strURL) { m_strURL = strURL; };
+  void setUrl(const std::string &strURL) { m_strURL = strURL; };
 
   /*!
     Get format for picture
@@ -2107,7 +2109,7 @@ class CMDF_Picture : public CMDF_Object {
     Set format for picture
     @param strFormat Format for picture
   */
-  void setFormat(std::string &strFormat) { m_strFormat = strFormat; };
+  void setFormat(const std::string &strFormat) { m_strFormat = strFormat; };
 
   /*
     Get date for object
@@ -2140,7 +2142,7 @@ class CMDF_Picture : public CMDF_Object {
   /*!
     Set description for picture
   */
-  void setDescription(std::string &strDescription, std::string &strLanguage)
+  void setDescription(const std::string &strDescription, const std::string &strLanguage)
   {
     m_mapDescription[strLanguage] = strDescription;
   };
@@ -2163,7 +2165,7 @@ class CMDF_Picture : public CMDF_Object {
     @param lang Language
     @param url Value info URL to set
   */
-  void setInfoURL(std::string lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -2236,7 +2238,7 @@ class CMDF_Video : public CMDF_Object {
     Set name of video
     @param strURL name
   */
-  void setName(std::string &name) { m_strName = name; };
+  void setName(const std::string &name) { m_strName = name; };
 
   /*!
     Get URL for video
@@ -2248,7 +2250,7 @@ class CMDF_Video : public CMDF_Object {
     Set URL for video
     @param strURL URL for video
   */
-  void setUrl(std::string &strURL) { m_strURL = strURL; };
+  void setUrl(const std::string &strURL) { m_strURL = strURL; };
 
   /*!
     Get format for video
@@ -2260,7 +2262,7 @@ class CMDF_Video : public CMDF_Object {
     Set format for video
     @param strFormat Format for video
   */
-  void setFormat(std::string &strFormat) { m_strFormat = strFormat; };
+  void setFormat(const std::string &strFormat) { m_strFormat = strFormat; };
 
   /*
     Get date for object
@@ -2293,7 +2295,7 @@ class CMDF_Video : public CMDF_Object {
   /*!
     Set description for video
   */
-  void setDescription(std::string &strDescription, std::string &strLanguage)
+  void setDescription(const std::string &strDescription, const std::string &strLanguage)
   {
     m_mapDescription[strLanguage] = strDescription;
   };
@@ -2324,7 +2326,7 @@ class CMDF_Video : public CMDF_Object {
     @param lang Language
     @param url Value info URL to set
   */
-  void setInfoURL(std::string lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -2404,7 +2406,7 @@ class CMDF_Firmware : public CMDF_Object {
     Set name of firmware
     @param strURL name
   */
-  void setName(std::string &name) { m_strName = name; };
+  void setName(const std::string &name) { m_strName = name; };
 
   /*!
     Get URL for firmware
@@ -2416,7 +2418,7 @@ class CMDF_Firmware : public CMDF_Object {
     Set URL
     @param url URL to set
   */
-  void setUrl(std::string &url) { m_strURL = url; };
+  void setUrl(const std::string &url) { m_strURL = url; };
 
   /*!
     Get target string for firmware
@@ -2535,7 +2537,7 @@ class CMDF_Firmware : public CMDF_Object {
     @param md5 MD5 checksum string to set
   */
 
-  void setMd5(std::string &md5) { m_strMd5 = md5; };
+  void setMd5(const std::string &md5) { m_strMd5 = md5; };
 
   /*!
     Assignment
@@ -2563,7 +2565,7 @@ class CMDF_Firmware : public CMDF_Object {
   /*!
     Set description for firmware
   */
-  void setDescription(std::string &strDescription, std::string &strLanguage)
+  void setDescription(const std::string &strDescription, const std::string &strLanguage)
   {
     m_mapDescription[strLanguage] = strDescription;
   };
@@ -2594,7 +2596,7 @@ class CMDF_Firmware : public CMDF_Object {
     @param lang Language
     @param url Value info URL to set
   */
-  void setInfoURL(std::string lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -2704,7 +2706,7 @@ class CMDF_Driver : public CMDF_Object {
     Set name of driver
     @param name name
   */
-  void setName(std::string &name) { m_strName = name; };
+  void setName(const std::string &name) { m_strName = name; };
 
   /*!
     Get URL for CMDF_Driver
@@ -2716,7 +2718,7 @@ class CMDF_Driver : public CMDF_Object {
     Set URL of driver
     @param url name
   */
-  void setUrl(std::string &url) { m_strURL = url; };
+  void setUrl(const std::string &url) { m_strURL = url; };
 
   /*!
     Get driver type for CMDF_Driver
@@ -2728,7 +2730,7 @@ class CMDF_Driver : public CMDF_Object {
     Set type of driver
     @param type Type of driver
   */
-  void setType(std::string &type) { m_strType = type; };
+  void setType(const std::string &type) { m_strType = type; };
 
   /*!
     Get driver type for CMDF_Driver
@@ -2740,7 +2742,7 @@ class CMDF_Driver : public CMDF_Object {
     Set architecture of driver
     @param arch Architecture of driver
   */
-  void setArchitecture(std::string &arch) { m_strArchitecture = arch; };
+  void setArchitecture(const std::string &arch) { m_strArchitecture = arch; };
 
   // Deprecated
   std::string getFormat(void) { return m_strArchitecture; };
@@ -2755,7 +2757,7 @@ class CMDF_Driver : public CMDF_Object {
     Set OS of driver
     @param os Type of driver
   */
-  void setOS(std::string &os) { m_strOS = os; };
+  void setOS(const std::string &os) { m_strOS = os; };
 
   /*!
     Get OS version for the driver
@@ -2767,7 +2769,7 @@ class CMDF_Driver : public CMDF_Object {
     Set OS version of driver
     @param osver Type of driver
   */
-  void setOSVer(std::string &osver) { m_strOSVer = osver; };
+  void setOSVer(const std::string &osver) { m_strOSVer = osver; };
 
   /*!
     Get version major for driver
@@ -2831,7 +2833,7 @@ class CMDF_Driver : public CMDF_Object {
     Set MD5 checksum
     @param md5 MD5 checksum to set as hex string.
   */
-  void setMd5(const std::string& md5) {m_strMd5 = md5; };
+  void setMd5(const std::string &md5) { m_strMd5 = md5; };
 
   /*
     Get date for object
@@ -2871,7 +2873,7 @@ class CMDF_Driver : public CMDF_Object {
   /*!
     Set description for picture
   */
-  void setDescription(std::string &strDescription, std::string &strLanguage)
+  void setDescription(const std::string &strDescription, const std::string &strLanguage)
   {
     m_mapDescription[strLanguage] = strDescription;
   };
@@ -2902,7 +2904,7 @@ class CMDF_Driver : public CMDF_Object {
     @param lang Language
     @param url Value info URL to set
   */
-  void setInfoURL(std::string lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -3004,7 +3006,7 @@ class CMDF_Setup : public CMDF_Object {
     Set name of setup
     @param strURL name
   */
-  void setName(std::string &name) { m_strName = name; };
+  void setName(const std::string &name) { m_strName = name; };
 
   /*!
     Get URL for setup
@@ -3016,7 +3018,7 @@ class CMDF_Setup : public CMDF_Object {
     Set URL for setup
     @param strURL URL for setup
   */
-  void setUrl(std::string &strURL) { m_strURL = strURL; };
+  void setUrl(const std::string &strURL) { m_strURL = strURL; };
 
   /*!
     Get format for setup
@@ -3028,7 +3030,7 @@ class CMDF_Setup : public CMDF_Object {
     Set format for setup
     @param strFormat Format for setup
   */
-  void setFormat(std::string &strFormat) { m_strFormat = strFormat; };
+  void setFormat(const std::string &strFormat) { m_strFormat = strFormat; };
 
   /*!
     Assignment
@@ -3050,7 +3052,7 @@ class CMDF_Setup : public CMDF_Object {
   /*!
     Set description for setup
   */
-  void setDescription(std::string &strDescription, std::string &strLanguage)
+  void setDescription(const std::string &strDescription, const std::string &strLanguage)
   {
     m_mapDescription[strLanguage] = strDescription;
   };
@@ -3093,7 +3095,7 @@ class CMDF_Setup : public CMDF_Object {
     @param lang Language
     @param url Value info URL to set
   */
-  void setInfoURL(std::string lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -3171,7 +3173,7 @@ class CMDF_Manual : public CMDF_Object {
     Set name of manual
     @param strURL manual
   */
-  void setName(std::string &name) { m_strName = name; }
+  void setName(const std::string &name) { m_strName = name; }
 
   /*!
     Get URL for manual
@@ -3241,7 +3243,7 @@ class CMDF_Manual : public CMDF_Object {
   /*!
     Set description for manual item
   */
-  void setDescription(std::string &strDescription, std::string &strLanguage)
+  void setDescription(const std::string &strDescription, const std::string &strLanguage)
   {
     m_mapDescription[strLanguage] = strDescription;
   };
@@ -3272,7 +3274,7 @@ class CMDF_Manual : public CMDF_Object {
     @param lang Language
     @param url Value info URL to set
   */
-  void setInfoURL(std::string lang, std::string &url) { m_mapInfoURL[lang] = url; };
+  void setInfoURL(const std::string lang, const std::string &url) { m_mapInfoURL[lang] = url; };
 
   /*!
     Get description map
@@ -3356,16 +3358,16 @@ class CMDF : public CMDF_Object {
       @return Return CURLE_OK if a valid file is downloaded, else a
               curl error code.
   */
-  CURLcode downLoadMDF(std::string &remoteFile, std::string &tempFile);
+  CURLcode downLoadMDF(const std::string &remoteFile, const std::string &tempFile);
 
   /*!
       Load MDF from local or remote storage and parse it into
       a MDF structure.
-      @param Filename or URL to MDF file.
+      @param file or URL to MDF file.
       @param blocalFile Asks for a local file if set to true.
       @return returns true on success, false on failure.
   */
-  bool load(std::string &remoteFile, bool bLocalFile = false);
+  bool load(const std::string &file, bool bLocalFile = false);
 
   /*!
       Format an MDF description so it can be shown
@@ -3392,7 +3394,7 @@ class CMDF : public CMDF_Object {
     Set Module name.
     @parm Module name to set
   */
-  void setModuleName(std::string &str) { m_name = str; };
+  void setModuleName(const std::string &str) { m_name = str; };
 
   /*!
     Get module model
@@ -3404,7 +3406,7 @@ class CMDF : public CMDF_Object {
     Set module model
     @Param Module model as string
   */
-  void setModuleModel(std::string &str) { m_strModule_Model = str; };
+  void setModuleModel(const std::string &str) { m_strModule_Model = str; };
 
   /*!
     Get module change date
@@ -3416,7 +3418,7 @@ class CMDF : public CMDF_Object {
     Set module change date
     @pparam str Module change date as ISO date formatted string
   */
-  void setModuleChangeDate(std::string &str) { m_strModule_changeDate = str; };
+  void setModuleChangeDate(const std::string &str) { m_strModule_changeDate = str; };
 
   /*!
     Get module version
@@ -3428,7 +3430,7 @@ class CMDF : public CMDF_Object {
     Set module version
     @param str Module version on stringt form
   */
-  void setModuleVersion(std::string &str) { m_strModule_Version = str; };
+  void setModuleVersion(const std::string &str) { m_strModule_Version = str; };
 
   /*!
     Get module buffer size
@@ -3452,7 +3454,7 @@ class CMDF : public CMDF_Object {
     Set Module copyright.
     @parm Module copyright to set
   */
-  void setModuleCopyright(std::string &str) { m_copyright = str; };
+  void setModuleCopyright(const std::string &str) { m_copyright = str; };
 
   /*!
     Return VSCP level for device. NOTE! that
@@ -3486,7 +3488,7 @@ class CMDF : public CMDF_Object {
     @return Return string with module description in selected language or
       in english if the language is not available.
   */
-  std::string getModuleDescription(std::string language = "en");
+  std::string getModuleDescription(const std::string language = "en");
 
   /*!
     Get the number of module descriptions available in different languages
@@ -3512,7 +3514,7 @@ class CMDF : public CMDF_Object {
     @return Return string with module info url in selected language or
       in english if the language is not available.
   */
-  std::string getModuleHelpUrl(std::string language = "en");
+  std::string getModuleHelpUrl(const std::string language = "en");
 
   /*!
     Get the number of module help URL's available in different mime types
@@ -3746,7 +3748,7 @@ class CMDF : public CMDF_Object {
     Create a set with sorted register offsets for a page
     @param set a std_set with offset uint32_t items
   */
-  void createRegisterStortedSet(std::set<uint32_t>& set, uint16_t page);
+  void createRegisterStortedSet(std::set<uint32_t> &set, uint16_t page);
 
   /*!
     Get all registers for a specific page
@@ -3807,7 +3809,7 @@ class CMDF : public CMDF_Object {
       @param name Name iof remote variable to search for.
       @return Pointer to CMDF_RemoteVariable class if found else NULL.
   */
-  CMDF_RemoteVariable *getRemoteVariable(std::string name);
+  CMDF_RemoteVariable *getRemoteVariable(const std::string& name);
 
   /*!
     Return remote variable list from its name