-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: remove shifts into variables in favour of positional parameter to local variables #188
Comments
There isn't a particular reason, it was just my preference. Using
Thank you! Please go ahead :) As xpanes is now mature and in the phase of refinement, any changes that improve readability are welcome. |
I understand it fully, Then if we have no special case to worry about and we can start working on this. As its just clean up its not top priority to fix it.
great! I hope when I get time I will look into this over the upcoming month's :) |
Most of the current xpanes functions looks like this example the moment:
While this works fine and from an resource optimization perspective, as multiple shifts is lightweight operations.
The readability takes a hit as all functions becomes very much larger than they need to be.
For most functions we should in theory be able to do following:
and in cases we need to fully reset the positional parameters we can do this instead:
@greymd is there any reason to why we utilize multiple shifting? Do you want me to proceed creating a patch to move the functions to the proposed syntax?
The text was updated successfully, but these errors were encountered: