Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipenv init and string replace: Regular expression substitute error: unknown substring #1

Closed
gregorias opened this issue Sep 5, 2022 · 0 comments · Fixed by #3
Closed

Pipenv init and string replace: Regular expression substitute error: unknown substring #1

gregorias opened this issue Sep 5, 2022 · 0 comments · Fixed by #3
Assignees
@gregorias
Labels
bug Something isn't working

Comments

@gregorias
Copy link
Owner

gregorias commented Sep 5, 2022 •
edited
Loading

Repro steps

Run

set foo '$PATH'; echo $foo

You'll see

string replace: Regular expression substitute error: unknown substring` outputted to stderr.

Discussion

This has probably the same root cause as fishgretel/fasd#22. I thought 3ce5c57 has fixed it entirely, but apparently it hasn't.
@gregorias gregorias added the bug Something isn't working label Sep 5, 2022
@gregorias gregorias self-assigned this Sep 5, 2022
gregorias added a commit that referenced this issue Mar 10, 2023
@gregorias
fix(#1): stop expanding variables
3a599f4 
The variable expansion' implementation was causing #1. It's an ugly
hard-to-maintain hack that only provides minor improvement, so I think
it's not worth keeping. I couldn't a proper way to do variable
expansion.
@gregorias gregorias mentioned this issue Mar 10, 2023
Merged
@gregorias gregorias linked a pull request Mar 10, 2023 that will close this issue
fix(#1): stop expanding variables #3
Merged
gregorias added a commit that referenced this issue Mar 10, 2023
@gregorias
fix(#1): stop expanding variables
41a02e2 
The variable expansion' implementation was causing #1. It's an ugly
hard-to-maintain hack that only provides minor improvement, so I think
it's not worth keeping. I couldn't a proper way to do variable
expansion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregorias gregorias

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1): stop expanding variables gregorias/fasd.fish
1 participant
@gregorias