[MAINTENANCE] Fix atomic diagnostic observed value renderers when used with datetime (#11033)

Co-authored-by: Bill Dirks <bill@greatexpectations.io>
Co-authored-by: Nathan Farmer <NathanFarmer@users.noreply.github.com>

Author: 3 people

great_expectations/expectations/core/expect_column_distinct_values_to_be_in_set.py

@@ -502,9 +502,14 @@ def _atomic_diagnostic_observed_value(
         for name, schema in renderer_configuration.params:
             if not name.startswith(ov_param_prefix):
                 continue
+            # try to coerce value_set to a type that can be compared with schema.value
+            coerced_value_set = {
+                parse_value_to_observed_type(observed_value=schema.value, value=value)
+                for value in value_set
+            }
             render_state = (
                 ObservedValueRenderState.EXPECTED.value
-                if schema.value in value_set
+                if schema.value in coerced_value_set
                 else ObservedValueRenderState.UNEXPECTED.value
             )
             renderer_configuration.params.__dict__[name].render_state = render_state

great_expectations/expectations/core/expect_column_distinct_values_to_contain_set.py

@@ -441,7 +441,16 @@ def _atomic_diagnostic_observed_value(
             template_str_list.append(f"${name}")
 
         for name, schema in expected_values:
-            if schema.value not in observed_value_set:
+            # try to coerce the expected value to a type that can be compared with observed values
+            if observed_value_set:
+                sample_observed_value = next(iter(observed_value_set))
+                expected_value = parse_value_to_observed_type(
+                    observed_value=sample_observed_value, value=schema.value
+                )
+            else:
+                expected_value = schema.value
+
+            if expected_value not in observed_value_set:
                 renderer_configuration.params.__dict__[
                     name
                 ].render_state = ObservedValueRenderState.MISSING.value

great_expectations/expectations/core/expect_column_distinct_values_to_equal_set.py

@@ -430,20 +430,24 @@ def _atomic_diagnostic_observed_value(
             param_prefix=ov_param_prefix,
             renderer_configuration=renderer_configuration,
         )
-
-        expected_value_set = set(renderer_configuration.kwargs.get("value_set", []))
         observed_value_set = set(
             result.get("result", {}).get("observed_value", []) if result else []
         )
+        sample_observed_value = next(iter(observed_value_set)) if observed_value_set else None
+        expected_value_set = {
+            parse_value_to_observed_type(observed_value=sample_observed_value, value=value)
+            for value in renderer_configuration.kwargs.get("value_set", [])
+        }
 
         observed_values = (
-            (name, sch)
-            for name, sch in renderer_configuration.params
+            (name, schema)
+            for name, schema in renderer_configuration.params
             if name.startswith(ov_param_prefix)
         )
+
         expected_values = (
-            (name, sch)
-            for name, sch in renderer_configuration.params
+            (name, schema)
+            for name, schema in renderer_configuration.params
             if name.startswith(expected_param_prefix)
         )
 
@@ -458,7 +462,11 @@ def _atomic_diagnostic_observed_value(
             template_str_list.append(f"${name}")
 
         for name, schema in expected_values:
-            if schema.value not in observed_value_set:
+            coerced_value = parse_value_to_observed_type(
+                observed_value=sample_observed_value,
+                value=schema.value,
+            )
+            if coerced_value not in observed_value_set:
                 renderer_configuration.params.__dict__[
                     name
                 ].render_state = ObservedValueRenderState.MISSING.value