Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement versioning for build targets from formal release branches #188

Closed
wants to merge 3 commits into from
Closed

Implement versioning for build targets from formal release branches #188

wants to merge 3 commits into from

Conversation

EnekoGonzalez3
Copy link
Contributor

Addition of versioning to build targets with the following format:
install_dir.1.0.1/bin/chrono_keeper

ibrodkin and others added 3 commits June 7, 2024 17:51
@ibrodkin
Merge tag '1.0.1'
af91b48
@EnekoGonzalez3
Merge remote-tracking branch 'origin/179-implement-versioning-for-bui…
2a5b1d7 
…ld-targets-from-formal-release-branches' into 179-implement-versioning-for-build-targets-from-formal-release-branches
@EnekoGonzalez3
Add versioning
0079c74
ibrodkin
ibrodkin requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@ibrodkin ibrodkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple subtasks that need to happen here:

  1. packaging
  2. pulling the code from git using the release version
  3. using the release version in cmake logic
    While the change you've made is not incorrect I do not see much value in doing just (3)

@EnekoGonzalez3
Copy link
Contributor Author

There are multiple subtasks that need to happen here:

  1. packaging
  2. pulling the code from git using the release version
  3. using the release version in cmake logic
    While the change you've made is not incorrect I do not see much value in doing just (3)

Totally agree. I did this because it was what I understood from the Summer 2024 TODO list. But this makes total sense to me, and I completely agree. I will update the issue with everything that needs to be done and start working on it.

@EnekoGonzalez3 EnekoGonzalez3 linked an issue Aug 28, 2024 that may be closed by this pull request
Implement Versioning for Build Targets from Formal Release Branches #179
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrodkin ibrodkin ibrodkin requested changes

@fkengun fkengun Awaiting requested review from fkengun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Versioning for Build Targets from Formal Release Branches
2 participants
@EnekoGonzalez3 @ibrodkin