Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with BERT batch generation #45

Open
aqibsaeed opened this issue Apr 15, 2020 · 1 comment
Open

Problem with BERT batch generation #45

aqibsaeed opened this issue Apr 15, 2020 · 1 comment

Comments

@aqibsaeed
Copy link

There is a problem with padding on line 73-75 . What if the sentence length is larger than maxlen? Then we end up with sequences of varying length and line 214 throws an error.
@Soothysay
Copy link

You cannot have sentences having length greater than maxlen. In cases where the length of a sentence is lesser than maxlen, the code applies padding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aqibsaeed @Soothysay