Skip to content

Commit 3192433

Browse files
authored
clarify links and attributes for dataloader batch spans (#66)
1 parent a173e8e commit 3192433

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

spec/spans.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,18 @@ groups:
312312
- Otherwise, this span SHOULD be a child of the `graphql.server`
313313
span, or of the resolver execution span that triggered the batch dispatch.
314314
315-
The span SHOULD have links to all resolver execution spans that
316-
contributed load requests to this batch, so that the causal
317-
relationship between resolvers and the batch is preserved.
315+
The span SHOULD have links to all `graphql.field.execution` spans
316+
whose resolvers contributed load requests to this batch, so that
317+
the causal relationship between resolvers and the batch is preserved.
318+
319+
Each link SHOULD include the following attributes:
320+
- `graphql.selection.field.coordinate`: The coordinate of the field
321+
that triggered the load request (e.g., `User.avatar`).
322+
323+
When the number of contributing resolvers exceeds a practical limit,
324+
instrumentations MAY cap the number of links to a configurable
325+
maximum. The `graphql.dataloader.batch.size` attribute still
326+
reflects the true batch size regardless of link count.
318327
attributes:
319328
- ref: graphql.processing.type
320329
requirement_level: required

0 commit comments

Comments
 (0)