chore: upgrade TypeScript to ^5.8.0 across workspace (prep for tsgo) (#4187)

Bumps the workspace onto TypeScript `^5.8.0` as preparatory work for
adopting the [TypeScript Native Preview
(`tsgo`)](https://github.com/microsoft/typescript-go) compiler in a
follow-up PR. `tsc --build` remains the source of truth for emit.

## Changes

* Unify TypeScript version at `^5.8.0` across the workspace
* A few typing fixes as a result of the version upgrade
* Bump `typedoc` from `^0.26.11` to `^0.28.19` for latest TS version
support
* Exclude `typedoc` output directory from graphiql's tsconfig

## Follow-ups

* A separate PR will introduce `@typescript/native-preview`, parallel
`check:tsgo` / `types:check:tsgo` scripts, a CI parity job, and VSCode
LSP configuration.
* `tsconfig` improvements, i.e. `verbatimModuleSyntax: true`
- Type-checking test files 👀

Author: trevor-scheer

.changeset/bump-typescript-to-5-8.md

@@ -0,0 +1,5 @@
+---
+'graphql-language-service-server': patch
+---
+
+Bump required TypeScript runtime dependency from `^5.3.3` to `^5.8.0`. This is preparatory work for adopting the TypeScript Native Preview (tsgo) compiler in a follow-up change, which tracks TypeScript 5.8 semantics. In practice `^5.3.3` already resolved to TS 5.8+ for most consumers; the new floor only affects consumers who pin TypeScript to 5.3–5.7 via resolutions or overrides.

package.json

@@ -120,8 +120,8 @@
     "rimraf": "^3.0.2",
     "ts-jest": "^27.1.5",
     "turbo": "^2.5.2",
-    "typedoc": "^0.26.11",
-    "typescript": "^4.6.3",
+    "typedoc": "^0.28.19",
+    "typescript": "^5.8.0",
     "vitest": "^2.1.9",
     "wgutils": "^1.2.5",
     "wsrun": "^5.2.4"

packages/cm6-graphql/package.json

@@ -31,7 +31,7 @@
     "@lezer/highlight": "^1.0.0",
     "@lezer/lr": "^1.0.0",
     "graphql": "^16.9.0",
-    "typescript": "^4.6.3"
+    "typescript": "^5.8.0"
   },
   "peerDependencies": {
     "@codemirror/autocomplete": "^6.0.0",

packages/codemirror-graphql/src/utils/info-addon.ts

@@ -10,13 +10,19 @@
 import CodeMirror from 'codemirror';
 import { GraphQLInfoOptions } from '../info';
 
+// CodeMirror's option system accepts the option value as the declared shape,
+// a boolean to enable/disable with defaults, or a function used as the render
+// helper. The handler below handles all three cases, so the parameter types
+// are widened accordingly.
+type GraphQLInfoOptionValue = GraphQLInfoOptions | boolean | (() => string);
+
 CodeMirror.defineOption(
   'info',
   false,
   (
     cm: CodeMirror.Editor,
-    options: GraphQLInfoOptions,
-    old?: GraphQLInfoOptions,
+    options: GraphQLInfoOptionValue,
+    old?: GraphQLInfoOptionValue,
   ) => {
     if (old && old !== CodeMirror.Init) {
       const oldOnMouseOver = cm.state.info.onMouseOver;
@@ -33,7 +39,7 @@ CodeMirror.defineOption(
   },
 );
 
-function createState(options: GraphQLInfoOptions) {
+function createState(options: GraphQLInfoOptionValue) {
   return {
     options:
       options instanceof Function

packages/graphiql-plugin-code-exporter/package.json

@@ -47,7 +47,7 @@
     "graphql": "^16.9.0",
     "react": "^19.1.0",
     "react-dom": "^19.1.0",
-    "typescript": "^4.6.3",
+    "typescript": "^5.8.0",
     "vite": "^6.3.4",
     "vite-plugin-dts": "^4.0.1"
   }

packages/graphiql-plugin-explorer/package.json

@@ -46,7 +46,7 @@
     "graphql": "^16.9.0",
     "react": "^19.1.0",
     "react-dom": "^19.1.0",
-    "typescript": "^4.6.3",
+    "typescript": "^5.8.0",
     "vite": "^6.3.4",
     "vite-plugin-dts": "^4.0.1",
     "vite-plugin-svgr": "^4.3.0"

packages/graphiql-react/package.json

@@ -78,7 +78,7 @@
     "graphql": "^16.9.0",
     "react": "^19.1.0",
     "react-dom": "^19.1.0",
-    "typescript": "^4.6.3",
+    "typescript": "^5.8.0",
     "vite": "^6.3.4",
     "vite-plugin-dts": "^4.5.3",
     "vite-plugin-svgr": "^4.3.0"

packages/graphiql-react/tsconfig.json

@@ -16,7 +16,6 @@
     "jsx": "react-jsx",
     "declaration": true,
     "noUncheckedIndexedAccess": true,
-    "importsNotUsedAsValues": "error",
     "types": ["vitest/globals", "@testing-library/jest-dom"]
   }
 }

packages/graphiql/cypress/support/commands.ts

@@ -90,7 +90,7 @@ Cypress.Commands.add(
       )
         .eq(0)
         .should(element => {
-          const actual = normalizeMonacoWhitespace(element.get(0).textContent!);
+          const actual = normalizeMonacoWhitespace(element.get(0).textContent);
           const expected = JSON.stringify(variables, null, 2);
           expect(actual).to.equal(expected);
         });
@@ -114,7 +114,7 @@ Cypress.Commands.add(
       )
         .eq(1)
         .should(element => {
-          const actual = normalizeMonacoWhitespace(element.get(0).textContent!);
+          const actual = normalizeMonacoWhitespace(element.get(0).textContent);
           const expected = headersString;
           expect(actual).to.equal(expected);
         });
@@ -144,7 +144,7 @@ function normalizeMonacoWhitespace(str: string): string {
 
 Cypress.Commands.add('containQueryResult', expected => {
   cy.get('section.result-window').should(element => {
-    const actual = normalizeMonacoWhitespace(element.get(0).textContent!);
+    const actual = normalizeMonacoWhitespace(element.get(0).textContent);
     expect(actual).to.contain(expected);
   });
 });

packages/graphiql/package.json

@@ -74,7 +74,7 @@
     "react": "^19.1.0",
     "react-dom": "^19.1.0",
     "start-server-and-test": "^1.10.11",
-    "typescript": "^4.6.3",
+    "typescript": "^5.8.0",
     "vite": "^6.3.4",
     "vite-plugin-dts": "^4.5.3",
     "vitest-canvas-mock": "0.3.3"