Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: log endpoint in freshness checker #839

Merged
merged 1 commit into from
Aug 6, 2024
Merged

common: log endpoint in freshness checker #839

merged 1 commit into from
Aug 6, 2024

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jan 8, 2024

Today indexers do not have a way to know what subgraph is "not fresh" this PR aims to introduce the endpoint of subgraph we consider is "not fresh" in the freshness checker

closes #803

@saihaj saihaj requested a review from fordN January 8, 2024 19:05
@fordN
Copy link
Contributor

fordN commented Jan 11, 2024

Hey sorry forgot to detail this before you submitted PR.

Would you mind altering commit format a bit to be consistent with past contributions on this repo?
<package_name>: <Commit description>

Lately I've been shortening the package name to leave more room for description, so using common instead of indexer-common. * for something that applies to all packages.

@saihaj saihaj force-pushed the saihaj803 branch 2 times, most recently from bb086fe to d0e4c24 Compare January 11, 2024 20:17
@saihaj saihaj changed the title feat(indexer-common): log endpoint in freshness checker common: log endpoint in freshness checker Jan 11, 2024
Today indexers do not have a way to know what subgraph is "not fresh" this PR aims to introduce the endpoint of subgraph we consider is "not fresh" in the freshness checker
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saihaj saihaj merged commit 3efefd9 into main Aug 6, 2024
10 checks passed
@saihaj saihaj deleted the saihaj803 branch August 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

Refine subgraph freshness check logs
2 participants