Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong exit number in a roundabout if a waypoint is inside #2930

Open
Oliv opened this issue Jan 18, 2024 · 3 comments
Open

Wrong exit number in a roundabout if a waypoint is inside #2930

Oliv opened this issue Jan 18, 2024 · 3 comments

Comments

@Oliv
Copy link

Oliv commented Jan 18, 2024

Describe the bug
When a waypoint is inside a roundabout, there are 2 main problems :

  • The instruction At roundabout, take exit X onto ... is on the waypoint coordinates, and not on the roundabout entrance
  • The exit count is wrong, since it counts starting from the waypoint and not the roundabout entrance

To Reproduce

Put a waypoint on a roundabout

Expected behavior

I think there are two possible behaviours:

  • Make an exception for the use case where a waypoint is inside a roundabout
  • Introduce the concept of "silent waypoints". Waypoints could be flagged a silent, and then would be used only for routing, and not for instructions

What are your thoughts on this ?

Screenshots & Logs

With a waypoint https://graphhopper.com/maps/?point=48.749273%2C2.309019&point=48.750055%2C2.30897&point=48.749432%2C2.308364&profile=car&layer=Omniscale
Capture d’écran du 2024-01-18 10-53-28

Without a waypoint https://graphhopper.com/maps/?point=48.749273%2C2.309019&point=48.749432%2C2.308364&profile=car&layer=Omniscale
Capture d’écran du 2024-01-18 11-05-34

Regards, Oliv

@karussell
Copy link
Member

No idea if this simplifies something, but IMO before fixing this issue we should first introduce an extra instruction for "leaving the roundabout": #1787

@Oliv
Copy link
Author

Oliv commented Feb 27, 2024

Hello again,

what is the status on this bug ? This is quite an issue for us since in bike / car profile we have quite a lot of wrong instructions.

Please let me know if you don't plan to have a look at this issue, and I'll try to fix it myself.

Regards, Olivier

@karussell
Copy link
Member

I don't think anyone is working on it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants